Removed some unecessary "use database" commands in tests.

Author: ckadluba

test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/Microsoft.Extensions.Configuration/ConfigurationExtensionsTests.cs

@@ -64,10 +64,8 @@ public void ColumnOptionsFromConfigSection()
                 .CreateLogger();
             Log.CloseAndFlush();
 
-            // from test TableCreatedWithCustomNames in CustomStandardColumnNames class
-            using(var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using(var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var logEvents = conn.Query<InfoSchema>($@"SELECT COLUMN_NAME AS ColumnName FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}'");
                 var infoSchema = logEvents as InfoSchema[] ?? logEvents.ToArray();
 

test/Serilog.Sinks.MSSqlServer.Tests/Configuration/Extensions/System.Configuration/ConfigurationExtensionsTests.cs

@@ -50,10 +50,8 @@ public void CustomStandardColumnNames()
                 .CreateLogger();
             Log.CloseAndFlush();
 
-            // from test TableCreatedWithCustomNames in CustomStandardColumnNames class
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var logEvents = conn.Query<InfoSchema>($@"SELECT COLUMN_NAME AS ColumnName FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}'");
                 var infoSchema = logEvents as InfoSchema[] ?? logEvents.ToArray();
 
@@ -79,9 +77,8 @@ public void CustomizedColumnList()
                 .CreateLogger();
             Log.CloseAndFlush();
 
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var logEvents = conn.Query<InfoSchema>($@"SELECT COLUMN_NAME AS ColumnName FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}'");
                 var infoSchema = logEvents as InfoSchema[] ?? logEvents.ToArray();
 

test/Serilog.Sinks.MSSqlServer.Tests/CustomStandardColumnNamesTests.cs

@@ -25,9 +25,8 @@ public void CustomIdColumn()
             var sink = new MSSqlServerSink(DatabaseFixture.LogEventsConnectionString, DatabaseFixture.LogTableName, 1, TimeSpan.FromSeconds(1), null, true, options, "dbo", null);
 
             // assert
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var logEvents = conn.Query<InfoSchema>($@"SELECT COLUMN_NAME AS ColumnName FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}'");
                 var infoSchema = logEvents as InfoSchema[] ?? logEvents.ToArray();
 
@@ -53,9 +52,8 @@ public void DefaultIdColumn()
 
             // assert
             var idColumnName = "Id";
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var logEvents = conn.Query<InfoSchema>($@"SELECT COLUMN_NAME AS ColumnName FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}'");
                 var infoSchema = logEvents as InfoSchema[] ?? logEvents.ToArray();
 
@@ -88,9 +86,8 @@ public void TableCreatedWithCustomNames()
             var sink = new MSSqlServerSink(DatabaseFixture.LogEventsConnectionString, DatabaseFixture.LogTableName, 1, TimeSpan.FromSeconds(1), null, true, options, "dbo", null);
 
             // assert
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var logEvents = conn.Query<InfoSchema>($@"SELECT COLUMN_NAME AS ColumnName FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}'");
                 var infoSchema = logEvents as InfoSchema[] ?? logEvents.ToArray();
 
@@ -114,9 +111,8 @@ public void TableCreatedWithDefaultNames()
             var sink = new MSSqlServerSink(DatabaseFixture.LogEventsConnectionString, DatabaseFixture.LogTableName, 1, TimeSpan.FromSeconds(1), null, true, options,  "dbo", null);
 
             // assert
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var logEvents = conn.Query<InfoSchema>($@"SELECT COLUMN_NAME AS ColumnName FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}'");
                 var infoSchema = logEvents as InfoSchema[] ?? logEvents.ToArray();
 

test/Serilog.Sinks.MSSqlServer.Tests/MiscFeaturesTests.cs

@@ -154,9 +154,8 @@ public void BigIntIdColumn()
             Log.CloseAndFlush();
 
             // assert
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var query = conn.Query<InfoSchema>($@"SELECT DATA_TYPE AS DataType FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}' AND COLUMN_NAME = '{columnOptions.Id.ColumnName}'");
                 var results = query as InfoSchema[] ?? query.ToArray();
 
@@ -186,9 +185,8 @@ public void XmlPropertyColumn()
             Log.CloseAndFlush();
 
             // assert
-            using (var conn = new SqlConnection(DatabaseFixture.MasterConnectionString))
+            using (var conn = new SqlConnection(DatabaseFixture.LogEventsConnectionString))
             {
-                conn.Execute($"use {DatabaseFixture.Database}");
                 var query = conn.Query<InfoSchema>($@"SELECT DATA_TYPE AS DataType FROM {DatabaseFixture.Database}.INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '{DatabaseFixture.LogTableName}' AND COLUMN_NAME = '{columnOptions.Properties.ColumnName}'");
                 var results = query as InfoSchema[] ?? query.ToArray();
 

test/Serilog.Sinks.MSSqlServer.Tests/TestUtils/DatabaseFixture.cs

@@ -10,6 +10,8 @@ public sealed class DatabaseFixture : IDisposable
         public static string Database => "LogTest";
         public static string LogTableName => "LogEvents";
 
+        private const string MasterConnectionString = @"Data Source=(localdb)\MSSQLLocalDB;Initial Catalog=Master;Integrated Security=True";
+
         private const string CreateLogEventsDatabase = @"
 EXEC ('CREATE DATABASE [{0}] ON PRIMARY 
 	(NAME = [{0}], 
@@ -26,7 +28,6 @@ WITH ROLLBACK IMMEDIATE
 DROP DATABASE [{Database}]
 ";
 
-        public static string MasterConnectionString => @"Data Source=(localdb)\MSSQLLocalDB;Initial Catalog=Master;Integrated Security=True";
         public static string LogEventsConnectionString => $@"Data Source=(localdb)\MSSQLLocalDB;Initial Catalog={Database};Integrated Security=True";
 
         public class FileName