implemented feedback

Author: f2calv

src/Serilog.Expressions/Extensions/Helpers.cs renamed to src/Serilog.Expressions/Expressions/Helpers.cs

@@ -12,31 +12,33 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#if NETSTANDARD2_0
+
 using System;
 
-namespace Serilog.Extensions
+namespace Serilog.Expressions
 {
     /// <summary>
     /// Helper methods.
     /// </summary>
-    public static class Helpers
+    internal static class Helpers
     {
-#if NETSTANDARD2_0
         /// <summary>
         /// Backport .NET Standard 2.1 additions to maintain .NET Standard 2.0 compatibility.
         /// Returns a value indicating whether a specified string occurs within this string, using the specified comparison rules.
+        /// 
+        /// From;
+        /// https://github.com/dotnet/runtime/issues/22198
+        /// https://stackoverflow.com/questions/444798/case-insensitive-containsstring/444818#444818
         /// </summary>
         /// <param name="source">input string</param>
         /// <param name="value">The string to seek.</param>
         /// <param name="comparisonType">Specifies the rule to use in the comparison.</param>
         /// <returns></returns>
         public static bool Contains(this string source, string value, StringComparison comparisonType)
         {
-            // See;
-            // https://github.com/dotnet/runtime/issues/22198
-            // https://stackoverflow.com/questions/444798/case-insensitive-containsstring/444818#444818
             return source?.IndexOf(value, comparisonType) >= 0;
         }
-#endif
     }
-}
+}
+#endif

src/Serilog.Expressions/Expressions/Runtime/RuntimeOperators.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using Serilog.Events;
 using Serilog.Expressions.Compilation.Linq;
-using Serilog.Extensions;
 
 // ReSharper disable ForCanBeConvertedToForeach, InvertIf, MemberCanBePrivate.Global, UnusedMember.Global
 

src/Serilog.Expressions/System.Diagnostics.CodeAnalysis/NotNullAttributes.cs

@@ -1,5 +1,8 @@
-#if NETSTANDARD2_0
-//https://medium.com/@SergioPedri/enabling-and-using-c-9-features-on-older-and-unsupported-runtimes-ce384d8debb
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+#if NETSTANDARD2_0
+//From: https://medium.com/@SergioPedri/enabling-and-using-c-9-features-on-older-and-unsupported-runtimes-ce384d8debb
 namespace System.Diagnostics.CodeAnalysis
 {
     /// <summary>Specifies that an output will not be null even if the corresponding type allows it. Specifies that an input argument was not null when the call returns.</summary>
@@ -19,9 +22,5 @@ internal sealed class MaybeNullWhenAttribute : Attribute
         /// <summary>Gets the return value condition.</summary>
         public bool ReturnValue { get; }
     }
-
-    // NOTE: you can find the full list of attributes in this gist:
-    // https://gist.github.com/Sergio0694/eb988b243dd4a720a66fe369b63e5b08.
-    // Keeping this one shorter so that the Medium embed doesn't take up too much space.
 }
 #endif