For external scope provider use enrichment with no side effects

pavel-faltynek · pavel-faltynek · commit 8bcc366f0d7b · 2024-05-22T11:56:59.000+02:00
diff --git a/src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLoggerProvider.cs b/src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLoggerProvider.cs
@@ -78,9 +78,7 @@ public void Enrich(LogEvent logEvent, ILogEventPropertyFactory propertyFactory)
 
         _externalScopeProvider?.ForEachScope((state, accumulatingLogEvent) =>
         {
-            var scope = new SerilogLoggerScope(this, state);
-
-            scope.EnrichAndCreateScopeItem(accumulatingLogEvent, propertyFactory, out var scopeItem);
+            SerilogLoggerScope.EnrichWithStateAndCreateScopeItem(accumulatingLogEvent, propertyFactory, state, out var scopeItem);
 
             if (scopeItem != null)
             {

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,7 @@ public void Enrich(LogEvent logEvent, ILogEventPropertyFactory propertyFactory)`
`78`	`78`
`79`	`79`	`_externalScopeProvider?.ForEachScope((state, accumulatingLogEvent) =>`
`80`	`80`	`{`
`81`		`- var scope = new SerilogLoggerScope(this, state);`
`82`		`-`
`83`		`- scope.EnrichAndCreateScopeItem(accumulatingLogEvent, propertyFactory, out var scopeItem);`
	`81`	`+ SerilogLoggerScope.EnrichWithStateAndCreateScopeItem(accumulatingLogEvent, propertyFactory, state, out var scopeItem);`
`84`	`82`
`85`	`83`	`if (scopeItem != null)`
`86`	`84`	`{`