Skip to content

Commit e7d116f

Browse files
authored
Merge pull request #70 from nblumhardt/removeformatting
Remove some redundant string formatting
2 parents 1e4727a + 2b6f2bb commit e7d116f

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,20 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except
9797

9898
if (messageTemplate == null)
9999
{
100-
var propertyName = state != null ? "State" :
101-
(formatter != null ? "Message" : null);
100+
string propertyName = null;
101+
if (state != null)
102+
{
103+
propertyName = "State";
104+
messageTemplate = "{State:l}";
105+
}
106+
else if (formatter != null)
107+
{
108+
propertyName = "Message";
109+
messageTemplate = "{Message:l}";
110+
}
102111

103112
if (propertyName != null)
104113
{
105-
messageTemplate = $"{{{propertyName}:l}}";
106114
LogEventProperty property;
107115
if (logger.BindProperty(propertyName, AsLoggableValue(state, formatter), false, out property))
108116
properties.Add(property);

0 commit comments

Comments
 (0)