Updated benchmarks based on advice from @mattwarren

Author: nblumhardt

test/Serilog.Formatting.Compact.Tests/BenchmarkDotNet.Artifacts/results/FormattingBenchmarks-report-github.md

@@ -11,9 +11,10 @@ JitModules=?
 Type=FormattingBenchmarks  Mode=Throughput  Toolchain=Core  
 
 ```
-                           Method |     Median |    StdDev | Scaled |
---------------------------------- |----------- |---------- |------- |
-                JsonFormatter1000 | 11.6479 ms | 0.3343 ms |   1.00 |
-         CompactJsonFormatter1000 |  6.1992 ms | 0.0448 ms |   0.53 |
-        RenderedJsonFormatter1000 | 14.9243 ms | 0.1439 ms |   1.28 |
- RenderedCompactJsonFormatter1000 |  7.0540 ms | 0.0535 ms |   0.61 |
+                       Method |     Median |    StdDev | Scaled |
+----------------------------- |----------- |---------- |------- |
+                JsonFormatter | 12.4016 us | 0.8737 us |   1.00 |
+         CompactJsonFormatter |  6.0621 us | 0.0359 us |   0.49 |
+        RenderedJsonFormatter | 15.6869 us | 0.9942 us |   1.26 |
+ RenderedCompactJsonFormatter |  6.8628 us | 0.4178 us |   0.55 |
+| 0.0535 ms |   0.61 |

test/Serilog.Formatting.Compact.Tests/BenchmarkDotNet.Artifacts/results/FormattingBenchmarks-report.csv

@@ -1,5 +1,6 @@
 Type;Method;Mode;Platform;Jit;Framework;Toolchain;Runtime;LaunchCount;WarmupCount;TargetCount;Affinity;Median;StdDev;Scaled
-FormattingBenchmarks;JsonFormatter1000;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;11.6479 ms;0.3343 ms;1.00
-FormattingBenchmarks;CompactJsonFormatter1000;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;6.1992 ms;0.0448 ms;0.53
-FormattingBenchmarks;RenderedJsonFormatter1000;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;14.9243 ms;0.1439 ms;1.28
-FormattingBenchmarks;RenderedCompactJsonFormatter1000;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;7.0540 ms;0.0535 ms;0.61
+FormattingBenchmarks;JsonFormatter;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;12.4016 us;0.8737 us;1.00
+FormattingBenchmarks;CompactJsonFormatter;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;6.0621 us;0.0359 us;0.49
+FormattingBenchmarks;RenderedJsonFormatter;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;15.6869 us;0.9942 us;1.26
+FormattingBenchmarks;RenderedCompactJsonFormatter;Throughput;Host;Host;Host;Core;Host;Auto;Auto;Auto;Auto;6.8628 us;0.4178 us;0.55
+0.0535 ms;0.61

test/Serilog.Formatting.Compact.Tests/BenchmarkDotNet.Artifacts/results/FormattingBenchmarks-report.html

@@ -11,9 +11,11 @@
 </code></pre>
 
 <table>
-<tr><th>                    Method</th><th>Median</th><th>StdDev</th><th>Scaled</th>
-</tr><tr><td>         JsonFormatter1000</td><td>11.6479 ms</td><td>0.3343 ms</td><td>1.00</td>
-</tr><tr><td>  CompactJsonFormatter1000</td><td>6.1992 ms</td><td>0.0448 ms</td><td>0.53</td>
-</tr><tr><td> RenderedJsonFormatter1000</td><td>14.9243 ms</td><td>0.1439 ms</td><td>1.28</td>
-</tr><tr><td>RenderedCompactJsonFormatter1000</td><td>7.0540 ms</td><td>0.0535 ms</td><td>0.61</td>
+<tr><th>                Method</th><th>Median</th><th>StdDev</th><th>Scaled</th>
+</tr><tr><td>         JsonFormatter</td><td>12.4016 us</td><td>0.8737 us</td><td>1.00</td>
+</tr><tr><td>  CompactJsonFormatter</td><td>6.0621 us</td><td>0.0359 us</td><td>0.49</td>
+</tr><tr><td> RenderedJsonFormatter</td><td>15.6869 us</td><td>0.9942 us</td><td>1.26</td>
+</tr><tr><td>RenderedCompactJsonFormatter</td><td>6.8628 us</td><td>0.4178 us</td><td>0.55</td>
+</tr></table>
+td>
 </tr></table>

test/Serilog.Formatting.Compact.Tests/FormattingBenchmarks.cs

@@ -27,37 +27,36 @@ public FormattingBenchmarks()
             _evt = collectorSink.LastCollected;
         }
 
-        void Run(ITextFormatter formatter, int iterations)
+        StringWriter _buffer;
+
+        [Setup]
+        public void InitBuffer()
         {
-            for (var i = 0; i < iterations; ++i)
-            {
-                var sw = new StringWriter();
-                formatter.Format(_evt, sw);
-            }
+            _buffer = new StringWriter();
         }
 
         [Benchmark(Baseline = true)]
-        public void JsonFormatter1000()
+        public void JsonFormatter()
         {
-            Run(_jsonFormatter, 1000);
+            _jsonFormatter.Format(_evt, _buffer);
         }
 
         [Benchmark]
-        public void CompactJsonFormatter1000()
+        public void CompactJsonFormatter()
         {
-            Run(_compactFormatter, 1000);
+            _compactFormatter.Format(_evt, _buffer);
         }
 
         [Benchmark]
-        public void RenderedJsonFormatter1000()
+        public void RenderedJsonFormatter()
         {
-            Run(_renderedJsonFormatter, 1000);
+            _renderedJsonFormatter.Format(_evt, _buffer);
         }
 
         [Benchmark]
-        public void RenderedCompactJsonFormatter1000()
+        public void RenderedCompactJsonFormatter()
         {
-            Run(_renderedCompactFormatter, 1000);
+            _renderedCompactFormatter.Format(_evt, _buffer);
         }
     }
 }