Add comments explaining behavior of DependencyContext.Default

tsimbalar · tsimbalar · commit 00178a1d4b6e · 2019-01-04T18:15:09.000+01:00
and protect against null
diff --git a/src/Serilog.Settings.Configuration/Settings/Configuration/Assemblies/AssemblyFinder.cs b/src/Serilog.Settings.Configuration/Settings/Configuration/Assemblies/AssemblyFinder.cs
@@ -16,7 +16,9 @@ protected static bool IsCaseInsensitiveMatch(string text, string textToFind)
 
         public static AssemblyFinder Auto()
         {
-            if (Assembly.GetEntryAssembly() != null)
+            // Need to check `Assembly.GetEntryAssembly()` first because 
+            // `DependencyContext.Default` throws an exception when `Assembly.GetEntryAssembly()` returns null
+            if (Assembly.GetEntryAssembly() != null && DependencyContext.Default != null)
             {
                 return new DependencyContextAssemblyFinder(DependencyContext.Default);
             }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,9 @@ protected static bool IsCaseInsensitiveMatch(string text, string textToFind)`
`16`	`16`
`17`	`17`	`public static AssemblyFinder Auto()`
`18`	`18`	`{`
`19`		`- if (Assembly.GetEntryAssembly() != null)`
	`19`	+ // Need to check `Assembly.GetEntryAssembly()` first because
	`20`	+ // `DependencyContext.Default` throws an exception when `Assembly.GetEntryAssembly()` returns null
	`21`	`+ if (Assembly.GetEntryAssembly() != null && DependencyContext.Default != null)`
`20`	`22`	`{`
`21`	`23`	`return new DependencyContextAssemblyFinder(DependencyContext.Default);`
`22`	`24`	`}`