Merge pull request #179 from marcjohne/patch-1

nblumhardt · web-flow · commit e5174268a95c · 2019-05-24T10:58:07.000+10:00
Added missing null checks for settingConfiguration
diff --git a/src/Serilog.Settings.Configuration/ConfigurationLoggerConfigurationExtensions.cs b/src/Serilog.Settings.Configuration/ConfigurationLoggerConfigurationExtensions.cs
@@ -46,6 +46,7 @@ public static LoggerConfiguration Configuration(
             IConfiguration configuration,
             DependencyContext dependencyContext = null)
         {
+            if (settingConfiguration == null) throw new ArgumentNullException(nameof(settingConfiguration));
             if (configuration == null) throw new ArgumentNullException(nameof(configuration));
 
             var assemblyFinder = dependencyContext == null
@@ -101,6 +102,7 @@ public static LoggerConfiguration Configuration(
             IConfiguration configuration,
             ConfigurationAssemblySource configurationAssemblySource)
         {
+            if (settingConfiguration == null) throw new ArgumentNullException(nameof(settingConfiguration));
             if (configuration == null) throw new ArgumentNullException(nameof(configuration));
 
             var assemblyFinder = AssemblyFinder.ForSource(configurationAssemblySource);

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ public static LoggerConfiguration Configuration(`
`46`	`46`	`IConfiguration configuration,`
`47`	`47`	`DependencyContext dependencyContext = null)`
`48`	`48`	`{`
	`49`	`+ if (settingConfiguration == null) throw new ArgumentNullException(nameof(settingConfiguration));`
`49`	`50`	`if (configuration == null) throw new ArgumentNullException(nameof(configuration));`
`50`	`51`
`51`	`52`	`var assemblyFinder = dependencyContext == null`
`@@ -101,6 +102,7 @@ public static LoggerConfiguration Configuration(`
`101`	`102`	`IConfiguration configuration,`
`102`	`103`	`ConfigurationAssemblySource configurationAssemblySource)`
`103`	`104`	`{`
	`105`	`+ if (settingConfiguration == null) throw new ArgumentNullException(nameof(settingConfiguration));`
`104`	`106`	`if (configuration == null) throw new ArgumentNullException(nameof(configuration));`
`105`	`107`
`106`	`108`	`var assemblyFinder = AssemblyFinder.ForSource(configurationAssemblySource);`