unit test for IConfig, IConfigSection, and config object-binding

Author: MV10

test/Serilog.Settings.Configuration.Tests/ConfigurationSettingsTests.cs

@@ -199,7 +199,6 @@ public void SinksAreConfiguredWithStaticMember()
             Assert.Equal(ConsoleThemes.Theme1, DummyConsoleSink.Theme);
         }
 
-
         [Theory]
         [InlineData("$switchName", true)]
         [InlineData("$SwitchName", true)]
@@ -391,6 +390,57 @@ public void LoggingLevelSwitchCanBeUsedForMinimumLevelOverrides()
             // ReSharper restore HeuristicUnreachableCode
         }
 
+        [Fact]
+        public void SinkWithIConfigurationArguments()
+        {
+            var json = @"{
+                ""Serilog"": {            
+                    ""Using"": [""TestDummies""],
+                    ""WriteTo"": [{
+                        ""Name"": ""DummyRollingFile"",
+                        ""Args"": {""pathFormat"" : ""C:\\"",
+                                   ""configurationSection"" : { ""foo"" : ""bar"" } }
+                    }]        
+                }
+            }";
+
+            // IConfiguration and IConfigurationSection arguments do not have
+            // default values so they will throw if they are not populated
+
+            var log = ConfigFromJson(json)
+                .CreateLogger();
+
+            DummyRollingFileSink.Emitted.Clear();
+
+            log.Write(Some.InformationEvent());
+
+            Assert.Equal(1, DummyRollingFileSink.Emitted.Count);
+        }
+
+        [Fact]
+        public void SinkWithConfigurationBindingArgument()
+        {
+            var json = @"{
+                ""Serilog"": {            
+                    ""Using"": [""TestDummies""],
+                    ""WriteTo"": [{
+                        ""Name"": ""DummyRollingFile"",
+                        ""Args"": {""pathFormat"" : ""C:\\"",
+                                   ""objectBinding"" : [ { ""foo"" : ""bar"" }, { ""abc"" : ""xyz"" } ] }
+                    }]        
+                }
+            }";
+
+            var log = ConfigFromJson(json)
+                .CreateLogger();
+
+            DummyRollingFileSink.Emitted.Clear();
+
+            log.Write(Some.InformationEvent());
+
+            Assert.Equal(1, DummyRollingFileSink.Emitted.Count);
+        }
+
 
         [Trait("Bugfix", "#91")]
         [Fact]

test/Serilog.Settings.Configuration.Tests/Serilog.Settings.Configuration.Tests.csproj

@@ -26,10 +26,12 @@
 
   <ItemGroup Condition="'$(TargetFramework)' == 'net452'">
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="1.1.1" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="1.1.2" />
   </ItemGroup>
 
   <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.0'">
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.0.1" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="2.0.1" />
   </ItemGroup>
 
   <ItemGroup>

test/TestDummies/DummyLoggerConfigurationExtensions.cs

@@ -6,6 +6,8 @@
 using Serilog.Core;
 using TestDummies.Console;
 using TestDummies.Console.Themes;
+using Microsoft.Extensions.Configuration;
+using System.Collections.Generic;
 
 namespace TestDummies
 {
@@ -35,6 +37,25 @@ public static LoggerConfiguration DummyRollingFile(
             return loggerSinkConfiguration.Sink(new DummyRollingFileSink(), restrictedToMinimumLevel);
         }
 
+        public static LoggerConfiguration DummyRollingFile(
+            this LoggerSinkConfiguration loggerSinkConfiguration,
+            IConfiguration appConfiguration,
+            IConfigurationSection configurationSection,
+            string pathFormat,
+            LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum)
+        {
+            return loggerSinkConfiguration.Sink(new DummyRollingFileSink(), restrictedToMinimumLevel);
+        }
+
+        public static LoggerConfiguration DummyRollingFile(
+            this LoggerSinkConfiguration loggerSinkConfiguration,
+            List<string> objectBinding,
+            string pathFormat,
+            LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum)
+        {
+            return loggerSinkConfiguration.Sink(new DummyRollingFileSink(), restrictedToMinimumLevel);
+        }
+
         public static LoggerConfiguration DummyRollingFile(
             this LoggerAuditSinkConfiguration loggerSinkConfiguration,
             string pathFormat,

test/TestDummies/TestDummies.csproj

@@ -16,9 +16,14 @@
     <PackageReference Include="Serilog" Version="2.6.0" />
   </ItemGroup>
 
+  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
+    <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="2.0.1" />
+  </ItemGroup>
+
   <ItemGroup Condition=" '$(TargetFramework)' == 'net452' ">
     <Reference Include="System" />
     <Reference Include="Microsoft.CSharp" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="1.1.2" />
   </ItemGroup>
 
 </Project>