Perf improvement

danelson · danelson · commit c44e5ecbad22 · 2023-09-13T09:23:43.000-05:00
diff --git a/src/Serilog.Sinks.OpenTelemetry/Sinks/OpenTelemetry/LogRecordBuilder.cs b/src/Serilog.Sinks.OpenTelemetry/Sinks/OpenTelemetry/LogRecordBuilder.cs
@@ -38,17 +38,19 @@ public static LogRecord ToLogRecord(LogEvent logEvent, IFormatProvider? formatPr
 
     public static void ProcessMessage(LogRecord logRecord, LogEvent logEvent, IncludedData includedFields, IFormatProvider? formatProvider)
     {
-        var renderedMessage = CleanMessageTemplateFormatter.Format(logEvent.MessageTemplate, logEvent.Properties, formatProvider);
-
-        if (!includedFields.HasFlag(IncludedData.TemplateBody) && renderedMessage.Trim() != "")
+        if (!includedFields.HasFlag(IncludedData.TemplateBody))
         {
-            logRecord.Body = new AnyValue
+            var renderedMessage = CleanMessageTemplateFormatter.Format(logEvent.MessageTemplate, logEvent.Properties, formatProvider);
+
+            if (renderedMessage.Trim() != "")
             {
-                StringValue = renderedMessage
-            };
+                logRecord.Body = new AnyValue
+                {
+                    StringValue = renderedMessage
+                };
+            }
         }
-
-        if (includedFields.HasFlag(IncludedData.TemplateBody) && logEvent.MessageTemplate.Text.Trim() != "")
+        else if (includedFields.HasFlag(IncludedData.TemplateBody) && logEvent.MessageTemplate.Text.Trim() != "")
         {
             logRecord.Body = new AnyValue
             {

Original file line number	Diff line number	Diff line change
`@@ -38,17 +38,19 @@ public static LogRecord ToLogRecord(LogEvent logEvent, IFormatProvider? formatPr`
`38`	`38`
`39`	`39`	`public static void ProcessMessage(LogRecord logRecord, LogEvent logEvent, IncludedData includedFields, IFormatProvider? formatProvider)`
`40`	`40`	`{`
`41`		`- var renderedMessage = CleanMessageTemplateFormatter.Format(logEvent.MessageTemplate, logEvent.Properties, formatProvider);`
`42`		`-`
`43`		`- if (!includedFields.HasFlag(IncludedData.TemplateBody) && renderedMessage.Trim() != "")`
	`41`	`+ if (!includedFields.HasFlag(IncludedData.TemplateBody))`
`44`	`42`	`{`
`45`		`- logRecord.Body = new AnyValue`
	`43`	`+ var renderedMessage = CleanMessageTemplateFormatter.Format(logEvent.MessageTemplate, logEvent.Properties, formatProvider);`
	`44`	`+`
	`45`	`+ if (renderedMessage.Trim() != "")`
`46`	`46`	`{`
`47`		`- StringValue = renderedMessage`
`48`		`- };`
	`47`	`+ logRecord.Body = new AnyValue`
	`48`	`+ {`
	`49`	`+ StringValue = renderedMessage`
	`50`	`+ };`
	`51`	`+ }`
`49`	`52`	`}`
`50`		`-`
`51`		`- if (includedFields.HasFlag(IncludedData.TemplateBody) && logEvent.MessageTemplate.Text.Trim() != "")`
	`53`	`+ else if (includedFields.HasFlag(IncludedData.TemplateBody) && logEvent.MessageTemplate.Text.Trim() != "")`
`52`	`54`	`{`
`53`	`55`	`logRecord.Body = new AnyValue`
`54`	`56`	`{`