Merge pull request #4572 from serlo/refactor/simplify-plugin-config

refactor(editor): simplify editor plugin config, remove testingsecret image upload

Author: elbotho

apps/web/src/components/pages/editor/education-plugin-examples.tsx

@@ -179,9 +179,7 @@ function ExampleWithEditSwitch({
             ]}
             styleReset={false}
             initialState={exampleState}
-            onChange={(state) => {
-              void debouncedSetState(state.document)
-            }}
+            onChange={(state) => debouncedSetState(state.document)}
             extraSerloPlugins={extraSerloPlugins}
             extraSerloRenderers={extraSerloRenderers}
           >

apps/web/src/serlo-editor-integration/extra-serlo-plugins.ts

@@ -1,7 +1,5 @@
 import { H5pPlugin } from './h5p'
-import { imagePlugin } from './image-with-serlo-config'
 
 export const extraSerloPlugins = {
   h5p: H5pPlugin,
-  image: imagePlugin,
 }

apps/web/src/serlo-editor-integration/image-with-serlo-config.ts

@@ -36,8 +36,6 @@ export class EditorWebComponent extends HTMLElement {
   private _initialState: InitialState = exampleInitialState
   private _currentState: unknown
 
-  private _testingSecret: string | null = null
-
   private _editorVariant: EditorVariant = 'unknown'
 
   private _plugins = defaultPlugins
@@ -129,14 +127,6 @@ export class EditorWebComponent extends HTMLElement {
     return this._history
   }
 
-  get testingSecret(): string | null {
-    return this._testingSecret
-  }
-
-  set testingSecret(newTestingSecret) {
-    if (newTestingSecret) this.setAttribute('testing-secret', newTestingSecret)
-  }
-
   get editorVariant(): EditorVariant {
     return this._editorVariant
   }
@@ -212,7 +202,6 @@ export class EditorWebComponent extends HTMLElement {
 
   mountReactComponent() {
     const initialStateAttr = this.getAttribute('initial-state')
-    const testingSecretAttr = this.getAttribute('testing-secret')
 
     const initialState: InitialState = initialStateAttr
       ? (JSON.parse(initialStateAttr) as unknown as any)
@@ -237,7 +226,6 @@ export class EditorWebComponent extends HTMLElement {
               <LazySerloEditor
                 editorVariant={this.editorVariant}
                 initialState={this.initialState}
-                _testingSecret={testingSecretAttr}
                 plugins={this.plugins}
                 isProductionEnvironment={this.isProductionEnvironment}
                 onChange={(newState) => {

packages/editor-web-component/src/editor-web-component.tsx

@@ -5,6 +5,8 @@ export interface EditorMeta {
   editorVariant: EditorVariant
   userId?: string
   ltik?: string
+  disableMediaUpload?: boolean
+  isProductionEnvironment?: boolean
 }
 
 export const EditorMetaContext = createContext<EditorMeta>({