Follow inspect format conventions, do not override to_s

Author: Ron Dahlgren

lib/serpapi/client.rb

@@ -181,18 +181,9 @@ def close
       @socket.close if @socket
     end
 
-    def to_s
-      # If the api_key is set, mask it
-      masked_api_key = if api_key && api_key.length > 4
-                         "#{api_key[0..3]}#{'*' * (api_key.length - 4)}"
-                       else
-                         api_key
-                       end
-      "SerpApi::Client(engine: #{engine}, api_key: #{masked_api_key}, persistent: #{persistent?}, timeout: #{timeout}s)"
-    end
-
     def inspect
-      to_s
+      masked_key = api_key && (api_key.length > 4 ? "#{api_key[..1]}****#{api_key[-2..]}" : '****')
+      "#<#{self.class} @engine=#{engine} @timeout=#{timeout} @persistent=#{persistent} api_key=#{masked_key}>"
     end
 
     private

spec/serpapi/client/client_spec.rb

@@ -96,23 +96,18 @@
     end
   end
 
-  it 'should not expose api_key in to_s and inspect' do
-    str = client.to_s
-    expect(str).to include('SerpApi::Client(engine: google, api_key: ')
-    expect(str).to_not include(ENV['SERPAPI_KEY'])
-
+  it 'should not expose api_key via inspect' do
     inspect_str = client.inspect
-    expect(inspect_str).to include('SerpApi::Client(engine: google, api_key: ')
+    expect(inspect_str).to include('#<SerpApi::Client @engine=google @timeout=')
     expect(inspect_str).to_not include(ENV['SERPAPI_KEY'])
   end
 
   it 'should gracefully handle api_key values shorter than 5 characters' do
     short_key_client = SerpApi::Client.new(engine: 'google', api_key: 'abcd', timeout: 10)
-    str = short_key_client.to_s
-    expect(str).to include('SerpApi::Client(engine: google, api_key: abcd')
-
     inspect_str = short_key_client.inspect
-    expect(inspect_str).to include('SerpApi::Client(engine: google, api_key: abcd')
+    expect(inspect_str).to include('#<SerpApi::Client @engine=google @timeout=')
+    expect(inspect_str).to_not include('abcd')
+
   end
 end