2.3.1 fix hpa setup

Author: Bobonium

18_horizontalPodAutoscaler.tf

@@ -18,6 +18,7 @@ resource "kubernetes_horizontal_pod_autoscaler_v2" "horizontalPodAutoscaler" {
     scale_target_ref {
       kind = var.podResourceType == "deployment" ? "Deployment" : "StatefulSet"
       name = var.podResourceType == "deployment" ? kubernetes_deployment_v1.deployment.0.metadata.0.name : kubernetes_stateful_set_v1.statefulset.0.metadata.0.name
+      api_version = "apps/v1"
     }
 
     dynamic "metric" {
@@ -40,8 +41,8 @@ resource "kubernetes_horizontal_pod_autoscaler_v2" "horizontalPodAutoscaler" {
             }
             target {
               type                = metric.value.target.type
-              average_value       = metric.value.target.averageValue
-              average_utilization = metric.value.target.averageUtilization
+              average_value       = metric.value.target.averageValue == 0 ? null : metric.value.target.averageValue
+              average_utilization = metric.value.target.averageUtilization == 0 ? null : metric.value.target.averageUtilization
               value               = metric.value.target.value
             }
           }
@@ -57,8 +58,8 @@ resource "kubernetes_horizontal_pod_autoscaler_v2" "horizontalPodAutoscaler" {
             }
             target {
               type                = metric.value.target.type
-              average_value       = metric.value.target.averageValue
-              average_utilization = metric.value.target.averageUtilization
+              average_value       = metric.value.target.averageValue == 0 ? null : metric.value.target.averageValue
+              average_utilization = metric.value.target.averageUtilization == 0 ? null : metric.value.target.averageUtilization
               value               = metric.value.target.value
             }
           }
@@ -69,8 +70,8 @@ resource "kubernetes_horizontal_pod_autoscaler_v2" "horizontalPodAutoscaler" {
             name = metric.value.name
             target {
               type                = metric.value.target.type
-              average_value       = metric.value.target.averageValue
-              average_utilization = metric.value.target.averageUtilization
+              average_value       = metric.value.target.averageValue == 0 ? null : metric.value.target.averageValue
+              average_utilization = metric.value.target.averageUtilization == 0 ? null : metric.value.target.averageUtilization
               value               = metric.value.target.value
             }
           }
@@ -86,8 +87,8 @@ resource "kubernetes_horizontal_pod_autoscaler_v2" "horizontalPodAutoscaler" {
             }
             target {
               type                = metric.value.target.type
-              average_value       = metric.value.target.averageValue
-              average_utilization = metric.value.target.averageUtilization
+              average_value       = metric.value.target.averageValue == 0 ? null : metric.value.target.averageValue
+              average_utilization = metric.value.target.averageUtilization == 0 ? null : metric.value.target.averageUtilization
               value               = metric.value.target.value
             }
           }

19_variables.tf

@@ -266,29 +266,29 @@ variable "horizontalPodAutoscaler" {
       }), null)
       target = optional(object({
         type               = optional(string, "Utilization")
-        averageValue       = optional(string, 0)
-        averageUtilization = optional(string, 75)
+        averageValue       = optional(number, 0)
+        averageUtilization = optional(number, 75)
         value              = optional(string, null)
       }), {})
     })), [{ type = "Resource", name = "cpu"}])
     behavior = optional(object({
       scaleDown = optional(object({
-        stabilizationWindowSeconds = optional(string, 300)
+        stabilizationWindowSeconds = optional(number, 300)
         selectPolicy               = optional(string, "Min")
         policies = optional(list(object({
-          periodSeconds = string
+          periodSeconds = number
           type          = optional(string, "Percent")
-          value         = string
-        })), [{ periodSeconds = 60, value = "25"}])
+          value         = number
+        })), [{ periodSeconds = 60, value = 25}])
       }), {})
       scaleUp = optional(object({
-        stabilizationWindowSeconds = optional(string, 300)
+        stabilizationWindowSeconds = optional(number, 0)
         selectPolicy               = optional(string, "Max")
         policies = optional(list(object({
-          periodSeconds = string
+          periodSeconds = number
           type          = optional(string, "Percent")
-          value         = string
-        })), [{ periodSeconds = 15, value = "100"}])
+          value         = number
+        })), [{ periodSeconds = 15, value = 100}])
       }), {})
     }), {})
   })

CHANGELOG.md

@@ -1,3 +1,12 @@
+## [2.3.1] - 2024-05-21
+
+- fix kubernetes_horizontal_pod_autoscaler_v2 not working because of missing apiVersion config
+- adjust defaults for hpa
+
+## [2.3.0] - 2024-04-22
+
+- replace kubernetes_horizontal_pod_autoscaler_v2beta2 with kubernetes_horizontal_pod_autoscaler_v2
+
 ## [2.2.0] - 2024-03-20
 
 - added boolean `var.service.loadbalancer.forceNodePortType` to allow spawning lb service as type nodeport