Improve code coverage

Author: emilien.escalle

lib/packExternalModules.js

@@ -153,28 +153,28 @@ function findExternalOrigin(issuer) {
 }
 
 function getExternalModules(stats) {
-  if (!stats.compilation.chunks) {
-    return [];
-  }
-
-  const externals = new Set();
-  for (const chunk of stats.compilation.chunks) {
-    if (!chunk.modulesIterable) {
-      continue;
-    }
+  if (stats.compilation.chunks) {
+    const externals = new Set();
+    for (const chunk of stats.compilation.chunks) {
+      if (!chunk.modulesIterable) {
+        continue;
+      }
 
-    // Explore each module within the chunk (built inputs):
-    for (const module of chunk.modulesIterable) {
-      if (isExternalModule(module)) {
-        externals.add({
-          origin: _.get(findExternalOrigin(module.issuer), 'rawRequest'),
-          external: getExternalModuleName(module)
-        });
+      // Explore each module within the chunk (built inputs):
+      for (const module of chunk.modulesIterable) {
+        if (isExternalModule(module)) {
+          externals.add({
+            origin: _.get(findExternalOrigin(module.issuer), 'rawRequest'),
+            external: getExternalModuleName(module)
+          });
+        }
       }
     }
+
+    return Array.from(externals);
   }
 
-  return Array.from(externals);
+  return [];
 }
 
 module.exports = {

tests/packExternalModules.test.js

@@ -332,24 +332,6 @@ describe('packExternalModules', () => {
         ]));
     });
 
-    it('should do nothing if webpackIncludeModules is empty', () => {
-      module.configuration = new Configuration();
-      module.compileStats = {
-        stats: {
-          compilation: {
-            chunks: []
-          }
-        }
-      };
-
-      return expect(module.packExternalModules()).to.be.fulfilled
-        .then(() => BbPromise.all([
-          expect(fsExtraMock.copy).to.not.have.been.called,
-          expect(packagerFactoryMock.get).to.not.have.been.called,
-          expect(writeFileSyncStub).to.not.have.been.called,
-        ]));
-    });
-
     it('should copy needed package sections if available', () => {
       const originalPackageJSON = {
         name: 'test-service',