Skip to content

Commit c85d044

Browse files
author
Frank Schmid
committed
Do not let lodash parse module names as path elements
1 parent 24f629d commit c85d044

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

lib/packExternalModules.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ function getProdModules(externalModules, packagePath, dependencyGraph) {
4141
} catch (e) {
4242
this.serverless.cli.log(`WARNING: Could not check for peer dependencies of ${module.external}`);
4343
}
44-
} else if (!_.has(packageJson, `devDependencies.${module.external}`)) {
44+
} else if (!packageJson.devDependencies || !packageJson.devDependencies[module.external]) {
4545
// Add transient dependencies if they appear not in the service's dev dependencies
46-
const originInfo = _.get(dependencyGraph, `dependencies.${module.origin}`, {});
47-
moduleVersion = _.get(originInfo, `dependencies.${module.external}.version`);
46+
const originInfo = _.get(dependencyGraph, 'dependencies', {})[module.origin] || {};
47+
moduleVersion = _.get(_.get(originInfo, 'dependencies', {})[module.external], 'version');
4848
if (!moduleVersion) {
4949
this.serverless.cli.log(`WARNING: Could not determine version of module ${module.external}`);
5050
}
@@ -208,7 +208,8 @@ module.exports = {
208208
splitModule[0] = '@' + splitModule[0];
209209
}
210210
const moduleVersion = _.join(_.tail(splitModule), '@');
211-
_.set(compositePackage, `dependencies.${_.first(splitModule)}`, moduleVersion);
211+
compositePackage.dependencies = compositePackage.dependencies || {};
212+
compositePackage.dependencies[_.first(splitModule)] = moduleVersion;
212213
});
213214
this.serverless.utils.writeFileSync(compositePackageJson, JSON.stringify(compositePackage, null, 2));
214215

0 commit comments

Comments
 (0)