Skip to content

Commit 044d0e2

Browse files
committed
test: update test names to better reflect the tests assertions
1 parent 8ef742c commit 044d0e2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/package/sns/validateSnsServiceProxy.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('#validateSnsServiceProxy()', () => {
2525
serverlessApigatewayServiceProxy = new ServerlessApigatewayServiceProxy(serverless, options)
2626
})
2727

28-
it('should validate the "topicName" property existence', async () => {
28+
it('should throw error if the "topicName" property doesn\'t exist', async () => {
2929
serverlessApigatewayServiceProxy.validated = {
3030
events: [
3131
{
@@ -43,7 +43,7 @@ describe('#validateSnsServiceProxy()', () => {
4343
)
4444
})
4545

46-
it('should validate the "topicName" property if it is string or AWS intrinsic function', async () => {
46+
it('should throw error if the "topicName" property is not a string or an AWS intrinsic function', async () => {
4747
serverlessApigatewayServiceProxy.validated = {
4848
events: [
4949
{
@@ -62,7 +62,7 @@ describe('#validateSnsServiceProxy()', () => {
6262
)
6363
})
6464

65-
it('should validate the "topicName" property that AWS intrinsic function is correct syntax', async () => {
65+
it('should throw error if the "topicName" property is missing the AWS intrinsic function "Fn::GetAtt"', async () => {
6666
serverlessApigatewayServiceProxy.validated = {
6767
events: [
6868
{
@@ -81,7 +81,7 @@ describe('#validateSnsServiceProxy()', () => {
8181
)
8282
})
8383

84-
it('should validate the "topicName" property if wrong AWS intrinsic function is specified', async () => {
84+
it('should throw error if the "topicName" property is an intrinsic function "Fn::GetAtt" but specifies a property other than TopicName', async () => {
8585
serverlessApigatewayServiceProxy.validated = {
8686
events: [
8787
{

0 commit comments

Comments
 (0)