feat(sqs): define less variables in SQS method compiler

Author: sambauers

lib/package/sqs/compileMethodsToSqs.js

@@ -2,6 +2,9 @@
 
 const _ = require('lodash')
 
+const requestParameterIsQuerystring = (_value, parameter) =>
+  parameter.trim().startsWith('integration.request.querystring.')
+
 module.exports = {
   compileMethodsToSqs() {
     this.validated.events.forEach((event) => {
@@ -48,12 +51,6 @@ module.exports = {
       'Fn::GetAtt': ['ApigatewayToSqsRole', 'Arn']
     }
 
-    const isQuerystring = (_value, parameter) =>
-      parameter.trim().startsWith('integration.request.querystring.')
-
-    const requestParametersQuerystrings = _.pickBy(http.requestParameters, isQuerystring)
-    const requestParametersOthers = _.omitBy(http.requestParameters, isQuerystring)
-
     const integration = {
       IntegrationHttpMethod: 'POST',
       Type: 'AWS',
@@ -69,9 +66,9 @@ module.exports = {
         {
           'integration.request.header.Content-Type': "'application/x-www-form-urlencoded'"
         },
-        requestParametersOthers
+        _.omitBy(http.requestParameters, requestParameterIsQuerystring)
       ),
-      RequestTemplates: this.getSqsIntegrationRequestTemplates(http, requestParametersQuerystrings)
+      RequestTemplates: this.getSqsIntegrationRequestTemplates(http)
     }
 
     let integrationResponse
@@ -146,9 +143,13 @@ module.exports = {
     }
   },
 
-  getSqsIntegrationRequestTemplates(http, requestParametersQuerystrings) {
+  getSqsIntegrationRequestTemplates(http) {
     const defaultRequestTemplates = this.getDefaultSqsRequestTemplates(http)
     const customRequestTemplates = _.get(http, ['request', 'template'])
+    let requestParametersQuerystrings = _.pickBy(
+      http.requestParameters,
+      requestParameterIsQuerystring
+    )
 
     if (_.isEmpty(customRequestTemplates) && !_.isEmpty(requestParametersQuerystrings)) {
       requestParametersQuerystrings = _.map(requestParametersQuerystrings, (value, parameter) => {