Merge pull request #98 from tomharvey/request-mapping-templates-dynamodb

feat(dynamodb): custom request mapping templates

Author: horike37

.travis.yml

@@ -3,12 +3,13 @@ language: node_js
 matrix:
   include:
     - node_js: '8.9'
-    - node_js: '10.6'
       env:
-        - INTEGRATION_TESTS=true
+        - DISABLE_INTEGRATION_TESTS=true
+    - node_js: '10.6'
     - node_js: '10.6'
       env:
-        - DISABLE_TESTS=true
+        - DISABLE_INTEGRATION_TESTS=true
+        - DISABLE_UNIT_TESTS=true
         - LINTING=true
 
 sudo: false
@@ -17,9 +18,9 @@ install:
   - travis_retry npm install
 
 script:
-  - if [[ -z "$DISABLE_TESTS" ]]; then npm run test; fi
-  - if [[ ! -z "$DISABLE_TESTS" && ! -z "$LINTING" ]]; then npm run lint; fi
-  - if [[ ! -z "$INTEGRATION_TESTS" && $TRAVIS_BRANCH == "master" && $TRAVIS_PULL_REQUEST == "false" ]]; then npm run integration-test; fi
+  - if [[ -z "$DISABLE_UNIT_TESTS" ]]; then npm run test; fi
+  - if [[ ! -z "$LINTING" ]]; then npm run lint; fi
+  - if [[ -z "$DISABLE_INTEGRATION_TESTS" ]]; then npm run integration-test; fi
 
 after_success:
-  - cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage
+  - cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage

lib/apiGateway/schema.js

@@ -288,7 +288,8 @@ const proxiesSchemas = {
       tableName: stringOrRef.required(),
       condition: Joi.string(),
       hashKey: dynamodbDefaultKeyScheme.required(),
-      rangeKey: dynamodbDefaultKeyScheme
+      rangeKey: dynamodbDefaultKeyScheme,
+      request
     })
   }),
   eventbridge: Joi.object({

lib/apiGateway/validate.test.js

@@ -2190,5 +2190,24 @@ describe('#validateServiceProxies()', () => {
 
       expect(() => serverlessApigatewayServiceProxy.validateServiceProxies()).to.not.throw()
     })
+
+    it('should not throw error if request is a mapping template object', () => {
+      serverlessApigatewayServiceProxy.serverless.service.custom = {
+        apiGatewayServiceProxies: [
+          {
+            dynamodb: {
+              tableName: 'yourTable',
+              path: 'dynamodb',
+              method: 'put',
+              action: 'PutItem',
+              hashKey: { pathParam: 'id', attributeType: 'S' },
+              request: { template: { 'application/json': 'mapping template' } }
+            }
+          }
+        ]
+      }
+
+      expect(() => serverlessApigatewayServiceProxy.validateServiceProxies()).to.not.throw()
+    })
   })
 })

lib/package/dynamodb/compileMethodsToDynamodb.test.js

@@ -393,6 +393,30 @@ describe('#compileMethodsToDynamodb()', () => {
         {}
       )
     })
+
+    it('should create a custom request template when one is given', () => {
+      const customRequestTemplate = "#set($inputRoot = $input.path('$'))\n{ }"
+      testPutItem(
+        {
+          hashKey: { pathParam: 'id', attributeType: 'S' },
+          rangeKey: { pathParam: 'range', attributeType: 'S' },
+          path: '/dynamodb/{id}/{range}',
+          condition: 'attribute_not_exists(id)',
+          action: 'PutItem',
+          request: {
+            template: {
+              'application/json': customRequestTemplate,
+              'application/x-www-form-urlencoded': customRequestTemplate
+            }
+          }
+        },
+        {
+          'application/json': customRequestTemplate,
+          'application/x-www-form-urlencoded': customRequestTemplate
+        },
+        {}
+      )
+    })
   })
 
   describe('#get method', () => {