chore: fix joi scheme for dynamodb

Author: horike37

lib/apiGateway/schema.js

@@ -160,70 +160,21 @@ const partitionKey = Joi.alternatives().try([
     )
 ])
 
-const allowedDynamodbActions = ['PutItem', 'GetItem', 'DeleteItem', 'UpdateItem']
-const dynamodbDefaultKeyScheme = Joi.alternatives().try([
-  Joi.string(),
-  Joi.object()
-    .keys({
-      pathParam: Joi.string(),
-      queryStringParam: Joi.string(),
-      attributeType: Joi.string().required()
-    })
-    .xor('pathParam', 'queryStringParam')
-    .error(
-      customErrorBuilder(
-        'object.xor',
-        'key must contain "pathParam" or "queryStringParam" and only one'
-      )
-    )
-])
-const hashKey = Joi.when('action', {
-  is: Joi.string()
-    .valid(allowedDynamodbActions)
-    .required(),
-  then: dynamodbDefaultKeyScheme,
-  otherwise: Joi.when('method', {
-    is: Joi.string()
-      .valid('post')
-      .insensitive()
-      .required(),
-    then: Joi.string()
-      .required()
-      .error(
-        customMultipleErrorBuilder({
-          'string.base': [
-            '"hashKey" must be a string when you define post "method" and not define',
-            ' "action" expolicitly since the hashKey value is auto-generated on AWS end'
-          ].join(''),
-          'any.required': [
-            '"hashKey" is required when you define post "method" and not define',
-            ' "action" expolicitly since the hashKey value is auto-generated on AWS end'
-          ].join('')
-        })
-      ),
-    otherwise: dynamodbDefaultKeyScheme
+const allowedDynamodbActions = ['PutItem', 'GetItem', 'DeleteItem']
+const dynamodbDefaultKeyScheme = Joi.object()
+  .keys({
+    pathParam: Joi.string(),
+    queryStringParam: Joi.string(),
+    attributeType: Joi.string().required()
   })
-})
+  .xor('pathParam', 'queryStringParam')
+  .error(
+    customErrorBuilder(
+      'object.xor',
+      'key must contain "pathParam" or "queryStringParam" and only one'
+    )
+  )
 
-const rangeKey = Joi.when('action', {
-  is: Joi.string()
-    .valid(allowedDynamodbActions)
-    .required(),
-  then: dynamodbDefaultKeyScheme,
-  otherwise: Joi.when('method', {
-    is: Joi.string()
-      .valid('post')
-      .insensitive()
-      .required(),
-    then: Joi.forbidden().error(
-      customErrorBuilder(
-        'any.unknown',
-        'you can not define "rangeKey" when post "method" is defined without "action"'
-      )
-    ),
-    otherwise: dynamodbDefaultKeyScheme
-  })
-})
 
 const request = Joi.object({
   template: Joi.object().required()
@@ -263,30 +214,11 @@ const proxiesSchemas = {
   }),
   dynamodb: Joi.object({
     dynamodb: proxy.append({
-      action: Joi.string()
-        .valid(allowedDynamodbActions)
-        .when('method', {
-          is: Joi.string()
-            .valid(['options', 'head', 'any'])
-            .insensitive(),
-          then: Joi.required().error(
-            customErrorBuilder(
-              'any.required',
-              '"action" is required when you define options, head, any to "method" property'
-            )
-          )
-        }),
-      tableName: Joi.alternatives()
-        .try([
-          Joi.string(),
-          Joi.object().keys({
-            Ref: Joi.string().required()
-          })
-        ])
-        .required(),
+      action: Joi.string().valid(allowedDynamodbActions).required(),
+      tableName: stringOrRef.required(),
       condition: Joi.string(),
-      hashKey,
-      rangeKey
+      hashKey: dynamodbDefaultKeyScheme.required(),
+      rangeKey: dynamodbDefaultKeyScheme
     })
   })
 }