test: added more failing tests for new feature

Author: theburningmonk

lib/deploy/stepFunctions/compileIamRole.test.js

@@ -1261,6 +1261,54 @@ describe('#compileIamRole', () => {
   });
 
   it('should support local function names', () => {
+    const getStateMachine = name => ({
+      name,
+      definition: {
+        StartAt: 'A',
+        States: {
+          A: {
+            Type: 'Task',
+            Resource: {
+              'Fn::GetAtt': ['hello-world', 'Arn'],
+            },
+            End: true,
+          },
+        },
+      },
+    });
+
+    serverless.service.functions = {
+      'hello-world': {
+        handler: 'hello-world.handler',
+      },
+    };
+
+    serverless.service.stepFunctions = {
+      stateMachines: {
+        myStateMachine1: getStateMachine('sm1'),
+      },
+    };
+
+    serverlessStepFunctions.compileIamRole();
+    const statements = serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources.IamRoleStateMachineExecution
+      .Properties.Policies[0].PolicyDocument.Statement;
+
+    const lambdaPermissions = statements.filter(s => _.isEqual(s.Action, ['lambda:InvokeFunction']));
+    expect(lambdaPermissions).to.have.lengthOf(1);
+
+    const lambdaArns = [
+      {
+        'Fn::GetAtt': [
+          'HelloDashworldLambdaFunction',
+          'Arn',
+        ],
+      },
+    ];
+    expect(lambdaPermissions[0].Resource).to.deep.eq(lambdaArns);
+  });
+
+  it('should support local function names for lambda::invoke resource type', () => {
     const getStateMachine = (name, functionName) => ({
       name,
       definition: {
@@ -1284,7 +1332,7 @@ describe('#compileIamRole', () => {
     const lambda1 = { Ref: 'hello-world' };
     const lambda2 = { 'Fn::GetAtt': ['hello-world', 'Arn'] };
 
-    serverless.functions = {
+    serverless.service.functions = {
       'hello-world': {
         handler: 'hello-world.handler',
       },

lib/deploy/stepFunctions/compileStateMachines.test.js

@@ -777,4 +777,75 @@ describe('#compileStateMachines', () => {
     const refParam = params[functionParam];
     expect(refParam).to.eql({ 'Fn::GetAtt': ['HelloDashworldLambdaFunction', 'Arn'] });
   });
+
+  it('should support local function names for lambda::invoke resource type', () => {
+    serverless.service.functions = {
+      'hello-world': {
+        handler: 'hello-world.handler',
+      },
+    };
+    serverless.service.stepFunctions = {
+      stateMachines: {
+        myStateMachine1: {
+          id: 'Test',
+          definition: {
+            StartAt: 'Lambda1',
+            States: {
+              Lambda1: {
+                Type: 'Task',
+                Resource: 'arn:aws:states:::lambda:invoke',
+                Parameters: {
+                  FunctionName: {
+                    Ref: 'hello-world',
+                  },
+                  Payload: {
+                    'ExecutionName.$': '$$.Execution.Name',
+                  },
+                },
+                Next: 'Lambda2',
+              },
+              Lambda2: {
+                Type: 'Task',
+                Resource: 'arn:aws:states:::lambda:invoke',
+                Parameters: {
+                  FunctionName: {
+                    'Fn::GetAtt': ['hello-world', 'Arn'],
+                  },
+                  Payload: {
+                    'ExecutionName.$': '$$.Execution.Name',
+                  },
+                },
+                End: true,
+              },
+            },
+          },
+        },
+      },
+    };
+
+    serverlessStepFunctions.compileStateMachines();
+    const stateMachine = serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .Test;
+
+    expect(stateMachine.Properties.DefinitionString).to.haveOwnProperty('Fn::Sub');
+    expect(stateMachine.Properties.DefinitionString['Fn::Sub']).to.have.lengthOf(2);
+
+    const [json, params] = stateMachine.Properties.DefinitionString['Fn::Sub'];
+    const modifiedDefinition = JSON.parse(json);
+
+    const lambda1 = modifiedDefinition.States.Lambda1;
+    expect(lambda1.Parameters.FunctionName.startsWith('${')).to.eq(true);
+    const lambda1ParamName = lambda1.Parameters.FunctionName.replace(/[${}]/g, '');
+    expect(params).to.haveOwnProperty(lambda1ParamName);
+    const lambda1Param = params[lambda1ParamName];
+    expect(lambda1Param).to.eql({ Ref: 'HelloDashworldLambdaFunction' });
+
+    const lambda2 = modifiedDefinition.States.Lambda2;
+    expect(lambda2.Parameters.FunctionName.startsWith('${')).to.eq(true);
+    const lambda2ParamName = lambda2.Parameters.FunctionName.replace(/[${}]/g, '');
+    expect(params).to.haveOwnProperty(lambda2ParamName);
+    const lambda2Param = params[lambda2ParamName];
+    expect(lambda2Param).to.eql({ 'Fn::GetAtt': ['HelloDashworldLambdaFunction', 'Arn'] });
+  });
 });