fix: test codes and coverage. fixed check logic for coverage

Author: shota

lib/deploy/events/apiGateway/iamRole.js

@@ -19,9 +19,7 @@ module.exports = {
 
     // generate IAM Role action by http.action parameter.
     this.pluginhttpValidated.events.forEach((event) => {
-      if (!_.has(event, 'http')) return;
-
-      if (_.has(event.http, 'action')) {
+      if (_.has(event, 'http.action')) {
         const actionName = `states:${event.http.action}`;
 
         if (iamRoleApiGatewayToStepFunctionsAction.indexOf(actionName) === -1) {

lib/deploy/events/apiGateway/iamRole.test.js

@@ -120,4 +120,56 @@ describe('#compileHttpIamRole()', () => {
         expect(resources).to.not.haveOwnProperty('ApigatewayToStepFunctionsRole');
       });
   });
+
+  it('Should add DescribeExecution action when it is assigned in config', () => {
+    serverlessStepFunctions.pluginhttpValidated = {
+      events: [
+        {
+          stateMachineName: 'first',
+          http: {
+            path: 'foo/bar1',
+            method: 'post',
+          },
+        },
+        {
+          stateMachineName: 'first',
+          http: {
+            path: 'foo/bar2',
+            method: 'post',
+            action: 'DescribeExecution',
+          },
+        },
+      ],
+    };
+
+    serverlessStepFunctions
+      .compileHttpIamRole().then(() => {
+        const properties = serverlessStepFunctions.serverless.service.provider
+          .compiledCloudFormationTemplate.Resources.ApigatewayToStepFunctionsRole.Properties;
+        expect(properties.Policies[0].PolicyDocument.Statement[0].Action)
+        .to.deep.equal(['states:StartExecution', 'states:DescribeExecution']);
+      });
+  });
+
+  it('Should not add DescribeExecution action when it is not assigned in config', () => {
+    serverlessStepFunctions.pluginhttpValidated = {
+      events: [
+        {
+          stateMachineName: 'first',
+          http: {
+            path: 'foo/bar1',
+            method: 'post',
+          },
+        },
+      ],
+    };
+
+    serverlessStepFunctions
+      .compileHttpIamRole().then(() => {
+        const properties = serverlessStepFunctions.serverless.service.provider
+          .compiledCloudFormationTemplate.Resources.ApigatewayToStepFunctionsRole.Properties;
+        expect(properties.Policies[0].PolicyDocument.Statement[0].Action)
+        .to.deep.equal(['states:StartExecution']);
+      });
+  });
 });

lib/deploy/events/apiGateway/methods.test.js

@@ -131,6 +131,19 @@ describe('#methods()', () => {
       .ResponseParameters['method.response.header.Access-Control-Allow-Origin'])
       .to.equal('\'*\'');
     });
+
+    it('should change passthroughBehavior and action when action is set',
+    () => {
+      expect(serverlessStepFunctions.getMethodIntegration('stateMachine', 'custom', {
+        action: 'DescribeExecution',
+      }).Properties.Integration.PassthroughBehavior)
+      .to.equal('WHEN_NO_TEMPLATES');
+
+      expect(serverlessStepFunctions.getMethodIntegration('stateMachine', 'custom', {
+        action: 'DescribeExecution',
+      }).Properties.Integration.Uri['Fn::Join'][1][2])
+      .to.equal(':states:action/DescribeExecution');
+    });
   });
 
   describe('#getIntegrationRequestTemplates()', () => {