fixed #23

Author: horike37

lib/index.js

@@ -210,7 +210,6 @@ class ServerlessStepFunctions {
     this.serverless.cli.log('Start to deploy for all stateMachies and activities...');
     return BbPromise.bind(this)
     .then(this.yamlParse)
-    .then(this.checkActivitySettings)
     .then(this.getActivityArns)
     .then(this.describeActivities)
     .then(this.createActivities)
@@ -250,7 +249,6 @@ class ServerlessStepFunctions {
     .then(this.deleteIamRoles)
     .then(this.getStateMachineNames)
     .then(this.deleteStateMachines)
-    .then(this.checkActivitySettings)
     .then(this.getActivityArns)
     .then(this.describeActivities)
     .then(this.deleteActivities)

lib/index.test.js

@@ -152,8 +152,6 @@ describe('ServerlessStepFunctions', () => {
     it('should run promise chain in order', () => {
       const yamlParseStub = sinon
         .stub(serverlessStepFunctions, 'yamlParse').returns(BbPromise.resolve());
-      const checkActivitySettingsStub = sinon
-        .stub(serverlessStepFunctions, 'checkActivitySettings').returns(BbPromise.resolve());
       const getActivityArnsStub = sinon
         .stub(serverlessStepFunctions, 'getActivityArns').returns(BbPromise.resolve());
       const describeActivitiesStub = sinon
@@ -176,8 +174,7 @@ describe('ServerlessStepFunctions', () => {
       return serverlessStepFunctions.allDeploy()
         .then(() => {
           expect(yamlParseStub.calledOnce).to.be.equal(true);
-          expect(checkActivitySettingsStub.calledAfter(yamlParseStub)).to.be.equal(true);
-          expect(getActivityArnsStub.calledAfter(checkActivitySettingsStub)).to.be.equal(true);
+          expect(getActivityArnsStub.calledAfter(yamlParseStub)).to.be.equal(true);
           expect(describeActivitiesStub.calledAfter(getActivityArnsStub)).to.be.equal(true);
           expect(createActivitiesStub.calledAfter(describeActivitiesStub)).to.be.equal(true);
           expect(getStateMachineNamesStub.calledAfter(createActivitiesStub)).to.be.equal(true);
@@ -188,7 +185,6 @@ describe('ServerlessStepFunctions', () => {
           expect(createStateMachinesStub.calledAfter(deleteStateMachinesStub)).to.be.equal(true);
 
           serverlessStepFunctions.yamlParse.restore();
-          serverlessStepFunctions.checkActivitySettings.restore();
           serverlessStepFunctions.getActivityArns.restore();
           serverlessStepFunctions.describeActivities.restore();
           serverlessStepFunctions.createActivities.restore();
@@ -212,8 +208,6 @@ describe('ServerlessStepFunctions', () => {
         .stub(serverlessStepFunctions, 'getStateMachineNames').returns(BbPromise.resolve());
       const deleteStateMachinesStub = sinon
         .stub(serverlessStepFunctions, 'deleteStateMachines').returns(BbPromise.resolve());
-      const checkActivitySettingsStub = sinon
-        .stub(serverlessStepFunctions, 'checkActivitySettings').returns(BbPromise.resolve());
       const getActivityArnsStub = sinon
         .stub(serverlessStepFunctions, 'getActivityArns').returns(BbPromise.resolve());
       const describeActivitiesStub = sinon
@@ -227,16 +221,14 @@ describe('ServerlessStepFunctions', () => {
           expect(deleteIamRolesStub.calledAfter(yamlParseStub)).to.be.equal(true);
           expect(getStateMachineNamesStub.calledAfter(deleteIamRolesStub)).to.be.equal(true);
           expect(deleteStateMachinesStub.calledAfter(getStateMachineNamesStub)).to.be.equal(true);
-          expect(checkActivitySettingsStub.calledAfter(deleteStateMachinesStub)).to.be.equal(true);
-          expect(getActivityArnsStub.calledAfter(checkActivitySettingsStub)).to.be.equal(true);
+          expect(getActivityArnsStub.calledAfter(deleteStateMachinesStub)).to.be.equal(true);
           expect(describeActivitiesStub.calledAfter(getActivityArnsStub)).to.be.equal(true);
           expect(deleteActivitiesStub.calledAfter(describeActivitiesStub)).to.be.equal(true);
 
           serverlessStepFunctions.yamlParse.restore();
           serverlessStepFunctions.deleteIamRoles.restore();
           serverlessStepFunctions.getStateMachineNames.restore();
           serverlessStepFunctions.deleteStateMachines.restore();
-          serverlessStepFunctions.checkActivitySettings.restore();
           serverlessStepFunctions.getActivityArns.restore();
           serverlessStepFunctions.describeActivities.restore();
           serverlessStepFunctions.deleteActivities.restore();
@@ -612,4 +604,3 @@ describe('ServerlessStepFunctions', () => {
     });
   });
 });
-

package.json

@@ -1,6 +1,6 @@
 {
   "name": "serverless-step-functions",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "The module is AWS Step Functions plugin for Serverless Framework",
   "main": "lib/index.js",
   "scripts": {