test(EventBridge Scheduler): ✅ test cases added and restructured the error message

Author: jappurohit041

lib/deploy/events/schedule/compileScheduledEvents.js

@@ -3,15 +3,15 @@
 const _ = require('lodash');
 const BbPromise = require('bluebird');
 
+const METHOD_SCHEDULER = 'scheduler';
+const METHOD_EVENT_BUS = 'eventBus';
 module.exports = {
   compileScheduledEvents() {
     const service = this.serverless.service;
     const permissionsBoundary = service.provider.rolePermissionsBoundary;
     _.forEach(this.getAllStateMachines(), (stateMachineName) => {
       const stateMachineObj = this.getStateMachine(stateMachineName);
       let scheduleNumberInFunction = 0;
-      const METHOD_SCHEDULER = 'scheduler';
-      const METHOD_EVENT_BUS = 'eventBus';
 
       if (stateMachineObj.events) {
         _.forEach(stateMachineObj.events, (event) => {
@@ -86,26 +86,21 @@ module.exports = {
                 if (method === METHOD_SCHEDULER) {
                   const errorMessage = [
                     'Cannot setup "schedule" event: "inputTransformer" is not supported with "scheduler" mode',
-                    'SCHEDULE_PARAMETER_NOT_SUPPORTED',
                   ].join('');
                   throw new this.serverless.classes
                     .Error(errorMessage);
-                } else {
-                  InputTransformer = this.formatInputTransformer(InputTransformer);
                 }
               }
               if (InputPath && method === METHOD_SCHEDULER) {
                 const errorMessage = [
                   'Cannot setup "schedule" event: "inputPath" is not supported with "scheduler" mode',
-                  'SCHEDULE_PARAMETER_NOT_SUPPORTED',
                 ].join('');
                 throw new this.serverless.classes
                   .Error(errorMessage);
               }
               if (timezone && method !== METHOD_SCHEDULER) {
                 const errorMessage = [
                   'Cannot setup "schedule" event: "timezone" is only supported with "scheduler" mode',
-                  'SCHEDULE_PARAMETER_NOT_SUPPORTED',
                 ].join('');
                 throw new this.serverless.classes
                   .Error(errorMessage);
@@ -146,7 +141,8 @@ module.exports = {
 
             let scheduleTemplate;
             let iamRoleTemplate;
-
+            // If condition for the event bridge schedular and it define
+            // resource template and iamrole for the same
             if (method === METHOD_SCHEDULER) {
               scheduleTemplate = `{
               "Type": "AWS::Scheduler::Schedule",
@@ -203,6 +199,8 @@ module.exports = {
             }
           }`;
             } else {
+              // else condition for the event rule and
+              // it define resource template and iamrole for the same
               scheduleTemplate = `{
                 "Type": "AWS::Events::Rule",
                 "Properties": {

lib/deploy/events/schedule/compileScheduledEvents.test.js

@@ -447,4 +447,87 @@ describe('#httpValidate()', () => {
       .FirstScheduleToStepFunctionsRole
       .Properties.PermissionsBoundary).to.equal('arn:aws:iam::myAccount:policy/permission_boundary');
   });
+
+  it('should have type of AWS::Scheduler::Schedule if method is scheduler', () => {
+    serverlessStepFunctions.serverless.service.stepFunctions = {
+      stateMachines: {
+        first: {
+          events: [
+            {
+              schedule: {
+                method: 'scheduler',
+                rate: 'rate(10 minutes)',
+                enabled: false,
+                timezone: 'Asia/Mumbai',
+              },
+            },
+          ],
+        },
+      },
+    };
+    serverlessStepFunctions.compileScheduledEvents();
+    expect(serverlessStepFunctions.serverless.service.provider.compiledCloudFormationTemplate.Resources.FirstStepFunctionsEventsRuleSchedule1.Type).to.equal('AWS::Scheduler::Schedule');
+  });
+
+  it('should have service as scheduler.amazonaws.com if method is scheduler', () => {
+    serverlessStepFunctions.serverless.service.stepFunctions = {
+      stateMachines: {
+        first: {
+          events: [
+            {
+              schedule: {
+                method: 'scheduler',
+                rate: 'rate(10 minutes)',
+                enabled: false,
+                timezone: 'Asia/Mumbai',
+              },
+            },
+          ],
+        },
+      },
+    };
+    serverlessStepFunctions.compileScheduledEvents();
+    expect(serverlessStepFunctions.serverless.service.provider.compiledCloudFormationTemplate.Resources.FirstScheduleToStepFunctionsRole.Properties.AssumeRolePolicyDocument.Statement[0].Principal.Service).to.equal('scheduler.amazonaws.com');
+  });
+
+  it('should define timezone when schedular and timezone given', () => {
+    serverlessStepFunctions.serverless.service.stepFunctions = {
+      stateMachines: {
+        first: {
+          events: [
+            {
+              schedule: {
+                method: 'scheduler',
+                rate: 'rate(10 minutes)',
+                enabled: false,
+                timezone: 'Asia/Mumbai',
+              },
+            },
+          ],
+        },
+      },
+    };
+    serverlessStepFunctions.compileScheduledEvents();
+
+    expect(serverlessStepFunctions.serverless.service.provider.compiledCloudFormationTemplate.Resources.FirstStepFunctionsEventsRuleSchedule1.Properties.ScheduleExpressionTimezone).to.equal('Asia/Mumbai');
+  });
+
+  it('should accept timezone only if method is scheduler', () => {
+    serverlessStepFunctions.serverless.service.stepFunctions = {
+      stateMachines: {
+        first: {
+          events: [
+            {
+              schedule: {
+                rate: 'rate(10 minutes)',
+                enabled: false,
+                timezone: 'Asia/Mumbai',
+              },
+            },
+          ],
+        },
+      },
+    };
+    expect(() => serverlessStepFunctions.compileScheduledEvents()).to.throw(Error);
+  });
 });