Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Commit 6a33f8c

Browse files
committed
Fixes #150 - Handle missing package config
Bug fix due to recent change introduced to support package configuratio in the manifest.
1 parent 35693f9 commit 6a33f8c

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

compile/packages/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@ class OpenWhiskCompilePackages {
2424
}
2525

2626
renameManifestPackages() {
27-
if (!this.serverless.service.resources.packages) return;
27+
const resources = this.serverless.service.resources
28+
if (!resources || !resources.packages) return;
2829

29-
const manifestPackages = this.serverless.service.resources.packages;
30+
const manifestPackages = resources.packages;
3031

3132
Object.keys(manifestPackages).forEach(packageKey => {
3233
const pack = manifestPackages[packageKey];

compile/packages/tests/index.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ describe('OpenWhiskCompilePackages', () => {
3737
});
3838

3939
describe('#renameManifestPackages()', () => {
40+
it('should handle config without resource packages', () => {
41+
openwhiskCompilePackages.serverless.service.resources = null
42+
openwhiskCompilePackages.renameManifestPackages();
43+
openwhiskCompilePackages.serverless.service.resources = {}
44+
openwhiskCompilePackages.renameManifestPackages();
45+
openwhiskCompilePackages.serverless.service.resources.packages = {}
46+
openwhiskCompilePackages.renameManifestPackages();
47+
})
48+
4049
it('should rename packages with explicit names', () => {
4150
openwhiskCompilePackages.serverless.service.resources.packages = {
4251
'first' : { name: 'firstchanged', parameters: { hello: 'world first' } },

0 commit comments

Comments
 (0)