fix(121): split operation state to separate file (#124)

Signed-off-by: lsytj0413 <[email protected]>

Signed-off-by: lsytj0413 <[email protected]>

Author: lsytj0413

model/operation_state.go

@@ -0,0 +1,53 @@
+// Copyright 2022 The Serverless Workflow Specification Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package model
+
+import (
+	"encoding/json"
+)
+
+// OperationState defines a set of actions to be performed in sequence or in parallel.
+type OperationState struct {
+	BaseState
+	// Specifies whether actions are performed in sequence or in parallel
+	// Defaults to sequential
+	ActionMode ActionMode `json:"actionMode,omitempty" validate:"required,oneof=sequential parallel"`
+	// Actions to be performed
+	Actions []Action `json:"actions" validate:"required,min=1,dive"`
+	// State specific timeouts
+	Timeouts *OperationStateTimeout `json:"timeouts,omitempty"`
+}
+
+type operationStateForUnmarshal OperationState
+
+// UnmarshalJSON unmarshal OperationState object from json bytes
+func (o *OperationState) UnmarshalJSON(data []byte) error {
+	v := operationStateForUnmarshal{
+		ActionMode: ActionModeSequential,
+	}
+	err := json.Unmarshal(data, &v)
+	if err != nil {
+		return err
+	}
+
+	*o = OperationState(v)
+	return nil
+}
+
+// OperationStateTimeout defines the specific timeout settings for operation state
+type OperationStateTimeout struct {
+	StateExecTimeout  *StateExecTimeout `json:"stateExecTimeout,omitempty"`
+	ActionExecTimeout string            `json:"actionExecTimeout,omitempty" validate:"omitempty,iso8601duration"`
+}

model/operation_state_test.go

@@ -0,0 +1,72 @@
+// Copyright 2022 The Serverless Workflow Specification Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package model
+
+import (
+	"encoding/json"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestOperationStateUnmarshalJSON(t *testing.T) {
+	type testCase struct {
+		desp   string
+		data   string
+		expect OperationState
+		err    string
+	}
+	testCases := []testCase{
+		{
+			desp: "all fields set",
+			data: `{"actionMode": "parallel"}`,
+			expect: OperationState{
+				ActionMode: ActionModeParallel,
+			},
+			err: ``,
+		},
+		{
+			desp: "actionMode unset",
+			data: `{}`,
+			expect: OperationState{
+				ActionMode: ActionModeSequential,
+			},
+			err: ``,
+		},
+		{
+			desp: "invalid object format",
+			data: `{"actionMode": parallel}`,
+			expect: OperationState{
+				ActionMode: ActionModeParallel,
+			},
+			err: `invalid character 'p' looking for beginning of value`,
+		},
+	}
+	for _, tc := range testCases {
+		t.Run(tc.desp, func(t *testing.T) {
+			v := OperationState{}
+			err := json.Unmarshal([]byte(tc.data), &v)
+
+			if tc.err != "" {
+				assert.Error(t, err)
+				assert.Regexp(t, tc.err, err)
+				return
+			}
+
+			assert.NoError(t, err)
+			assert.Equal(t, tc.expect, v)
+		})
+	}
+}

model/states.go

@@ -136,23 +136,6 @@ func (s *BaseState) GetStateDataFilter() *StateDataFilter { return s.StateDataFi
 // GetMetadata ...
 func (s *BaseState) GetMetadata() *Metadata { return s.Metadata }
 
-// OperationState Defines actions be performed. Does not wait for incoming events
-type OperationState struct {
-	BaseState
-	// Specifies whether actions are performed in sequence or in parallel
-	ActionMode ActionMode `json:"actionMode,omitempty"`
-	// Actions to be performed
-	Actions []Action `json:"actions" validate:"required,min=1,dive"`
-	// State specific timeouts
-	Timeouts *OperationStateTimeout `json:"timeouts,omitempty"`
-}
-
-// OperationStateTimeout ...
-type OperationStateTimeout struct {
-	StateExecTimeout  *StateExecTimeout `json:"stateExecTimeout,omitempty"`
-	ActionExecTimeout string            `json:"actionExecTimeout,omitempty" validate:"omitempty,min=1"`
-}
-
 // InjectState ...
 type InjectState struct {
 	BaseState