Added GetNumState for State Type WorkflowUtils #127

Signed-off-by: manick02 <[email protected]>

Author: manick02

utils/src/main/java/io/serverlessworkflow/utils/WorkflowUtils.java

@@ -29,9 +29,10 @@
 import java.util.stream.Collectors;
 
 /** Provides common utility methods to provide most often needed answers from a workflow */
+@SuppressWarnings("StreamToLoop")
 public final class WorkflowUtils {
   private static final int DEFAULT_STARTING_STATE_POSITION = 0;
-  private static final int DEFAULT_STATE_COUNT = 0;
+  private static final long DEFAULT_STATE_COUNT = 0;
 
   /**
    * Gets State matching Start state. If start is not present returns first state. If start is
@@ -268,21 +269,25 @@ public static List<Action> getActionsForFunctionDefinition(
 
   /**
    * Gets Num of State in the workflow does not consider child workflow
+   *
    * @param workflow
    * @return
    */
-  public static int getNumOfStates(Workflow workflow) {
+  public static long getNumOfStates(Workflow workflow) {
     return hasStates(workflow) ? workflow.getStates().size() : DEFAULT_STATE_COUNT;
   }
 
   /**
+   * Gets Num of States for State Type
    *
    * @param workflow
    * @param type
    * @return
    */
-  public static int getNumOfStates(Workflow workflow,DefaultState.Type type) {
-    return hasStates(workflow) ? workflow.getStates().size() : DEFAULT_STATE_COUNT;
+  public static long getNumOfStates(Workflow workflow, DefaultState.Type type) {
+    return hasStates(workflow)
+        ? workflow.getStates().stream().filter(state -> state.getType() == type).count()
+        : DEFAULT_STATE_COUNT;
   }
 
   private static List<Action> getActionsWhichUsesFunctionDefinition(

utils/src/test/java/io/serverlessworkflow/util/GetNumTests.java

@@ -19,6 +19,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import io.serverlessworkflow.api.Workflow;
+import io.serverlessworkflow.api.states.DefaultState;
 import io.serverlessworkflow.util.testutil.TestUtils;
 import io.serverlessworkflow.utils.WorkflowUtils;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -40,4 +41,13 @@ public void testGetNumStatesForNoStateInWorkflow(String workflowWithStates) {
     int expectedStatesCount = 0;
     assertEquals(expectedStatesCount, WorkflowUtils.getNumOfStates(workflow));
   }
+
+  @ParameterizedTest
+  @ValueSource(strings = {"/getStates/workflowwithstates.yml"})
+  public void testGetNumStatesOfEventType(String workflowWithStates) {
+    Workflow workflow = TestUtils.createWorkflowFromTestResource(workflowWithStates);
+    int expectedStatesCount = 2;
+    assertEquals(
+        expectedStatesCount, WorkflowUtils.getNumOfStates(workflow, DefaultState.Type.EVENT));
+  }
 }