adding no-param test

Signed-off-by: Tihomir Surdilovic <[email protected]>

Author: Tihomir Surdilovic

api/src/main/java/io/serverlessworkflow/api/deserializers/FunctionRefDeserializer.java

@@ -61,7 +61,7 @@ public FunctionRef deserialize(JsonParser jp,
         if (!node.isObject()) {
             functionRef.setRefName(node.asText());
             ObjectMapper objectMapper = new ObjectMapper();
-            functionRef.setParameters(objectMapper.readTree("{}"));
+            functionRef.setParameters(null);
             return functionRef;
         } else {
             if(node.get("parameters") != null) {

api/src/test/java/io/serverlessworkflow/api/test/MarkupToWorkflowTest.java

@@ -316,4 +316,33 @@ public void testFunctionRefJsonParams(String workflowLocation) {
         assertEquals("Pluto", params.get("body").get("name").asText());
         assertEquals("${ .pet.tagnumber }", params.get("body").get("tag").asText());
     }
+
+    @ParameterizedTest
+    @ValueSource(strings = {"/features/functionrefnoparams.json", "/features/functionrefnoparams.yml"})
+    public void testFunctionRefNoParams(String workflowLocation) {
+        Workflow workflow = Workflow.fromSource(WorkflowTestUtils.readWorkflowFile(workflowLocation));
+
+        assertNotNull(workflow);
+        assertNotNull(workflow.getId());
+        assertNotNull(workflow.getName());
+        assertNotNull(workflow.getStates());
+
+        assertNotNull(workflow.getStates());
+        assertTrue(workflow.getStates().size() == 1);
+        assertTrue(workflow.getStates().get(0) instanceof OperationState);
+
+        OperationState operationState = (OperationState) workflow.getStates().get(0);
+        assertNotNull(operationState.getActions());
+        assertEquals(2, operationState.getActions().size());
+        List<Action> actions = operationState.getActions();
+        assertNotNull(actions.get(0).getFunctionRef());
+        assertNotNull(actions.get(1).getFunctionRef());
+        assertEquals("addPet", actions.get(0).getFunctionRef().getRefName());
+        assertEquals("addPet", actions.get(1).getFunctionRef().getRefName());
+
+        JsonNode params = actions.get(0).getFunctionRef().getParameters();
+        assertNull(params);
+        JsonNode params2 = actions.get(1).getFunctionRef().getParameters();
+        assertNull(params);
+    }
 }

api/src/test/resources/features/functionrefnoparams.json

@@ -0,0 +1,23 @@
+{
+  "id": "functionrefparams",
+  "version": "1.0",
+  "name": "Function Ref Params Test",
+  "states": [
+    {
+      "name": "AddPluto",
+      "type": "operation",
+      "start": true,
+      "actions": [
+        {
+          "functionRef": {
+            "refName": "addPet"
+          }
+        },
+        {
+          "functionRef": "addPet"
+        }
+      ],
+      "end": true
+    }
+  ]
+}

api/src/test/resources/features/functionrefnoparams.yml

@@ -0,0 +1,12 @@
+id: functionrefparams
+version: '1.0'
+name: Function Ref Params Test
+states:
+  - name: AddPluto
+    type: operation
+    start: true
+    actions:
+      - functionRef:
+          refName: addPet
+      - functionRef: addPet
+    end: true