Fix code review comments

 - Return null when workflow is null
 - Comment fix
 - Simplify return default start state

Signed-off-by: cb-manick <[email protected]>

Author: cb-manick

utils/src/main/java/io/serverlessworkflow/utils/WorkflowUtils.java

@@ -18,27 +18,25 @@
 import io.serverlessworkflow.api.Workflow;
 import io.serverlessworkflow.api.interfaces.State;
 import io.serverlessworkflow.api.start.Start;
-import java.util.Objects;
 
 /** Provides common utility methods to provide most often needed answers from a workflow */
 public final class WorkflowUtils {
-
+  private static int DEFAULT_STATE = 0;
   /**
-   * Gets State matching Start state name If start is not present returns first state Returns null
-   * otherwise
+   * Gets State matching Start state.If start is not present returns first state otherwise Returns
+   * null
    *
    * @param workflow workflow
    * @return {@code state} when present else returns {@code null}
    */
   public static State getStartingState(Workflow workflow) {
-    Objects.requireNonNull(workflow);
-    if (workflow.getStates() == null || workflow.getStates().isEmpty()) {
+    if (workflow == null || workflow.getStates() == null || workflow.getStates().isEmpty()) {
       return null;
     }
 
     Start start = workflow.getStart();
     if (start == null) {
-      return workflow.getStates().stream().findFirst().get();
+      return workflow.getStates().get(DEFAULT_STATE);
     } else {
       return workflow.getStates().stream()
           .filter(state -> state.getName().equals(start.getStateName()))

utils/src/test/java/io/serverlessworkflow/util/StartStateTest.java

@@ -57,6 +57,7 @@ public void testGetStartStateForWorkflowWithNoState(String workflowWithNoState)
 
   @Test
   public void testGetStateForNullWorkflow() {
-    assertThrows(NullPointerException.class, () -> WorkflowUtils.getStartingState(null));
+    State startingState = WorkflowUtils.getStartingState(null);
+    assertNull(startingState);
   }
 }