Remove Makefile, make spotless format and add headers on mvn clean

Signed-off-by: Ricardo Zanini <[email protected]>

Author: ricardozanini

.githooks/pre-commit

@@ -2,39 +2,45 @@ name: sdk-java Verify
 
 on:
   push:
-    branches:
-      - main
+    branches: [ main ]
   pull_request:
-    branches:
-      - main
+    branches: [ main ]
 
 jobs:
-  build:
+  lint:
+    name: Lint (Spotless + Checkstyle)
     runs-on: ubuntu-latest
-
     steps:
-      # 1. Checkout this repo
       - name: Checkout sdk-java
         uses: actions/checkout@v4
 
-      # 2. Set up JDK 17 for both builds
       - name: Set up JDK 17
         uses: actions/setup-java@v4
         with:
           distribution: temurin
           java-version: 17
-          cache: 'maven'
+          cache: maven
 
-      - name: Check formatting
-        run: |
-          make ci
+      - name: Spotless + Checkstyle (fail fast)
+        run: mvn -B -DskipTests spotless:check checkstyle:check
 
-      # 3. Verify the main sdk-java project, excluding the two agentic modules
-      - name: Verify with Maven
-        run: |
-          mvn -B -f pom.xml clean install verify -am
+  build:
+    name: Build & Verify
+    needs: lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout sdk-java
+        uses: actions/checkout@v4
+
+      - name: Set up JDK 17
+        uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: 17
+          cache: maven
 
-      # 4. Verify examples
-      - name: Verify Examples with Maven
+      - name: Verify with Maven (core)
         run: |
-          mvn -B -f examples/pom.xml clean install verify
+          mvn -B -f pom.xml clean verify
+
+      # TODO: run examples once we fix the close issue

.github/workflows/maven-verify.yml

@@ -6,12 +6,11 @@ Thanks for helping improve this project! This guide explains the local dev setup
 
 ## TL;DR (Fast path)
 
-1. **Install prerequisites:** JDK 17+, Maven 3.8+, Git, Make, Bash.
+1. **Install prerequisites:** JDK 17+, Maven 3.8+, Git.
 2. **Clone** the repo and create a branch: `git checkout -b my-fix`.
-3. **Install the repo’s pre-commit hook:** `make hooks` (one-time).
-4. **Commit normally.** The pre-commit hook will auto-format Java files and **add license headers**, restage the changes, and let the commit proceed.
-5. **Before pushing:** `make check` to run Spotless + Checkstyle locally.
-6. **Open a PR** with a clear title and description.
+3. **Build locally:** run `mvn clean install` from the repo root. Spotless will **apply formatting and license headers** during the build.
+4. **Before pushing:** run `mvn -DskipTests spotless:check checkstyle:check`.
+5. **Open a PR** with a clear title and description.
 
 ---
 
@@ -28,17 +27,9 @@ Thanks for helping improve this project! This guide explains the local dev setup
 We use **Spotless** (Maven) to:
 
 * Format Java with **google-java-format**.
-* Insert/normalize **license headers** from `config/license-header.txt`.
+* Insert/normalize **license headers** (the header content is defined **inline** in the parent POM’s `<licenseHeader>` configuration).
 
-> **Do not** hand-format files or hand-edit headers; let Spotless do it. The pre-commit hook runs `spotless:apply` for staged Java files.
-
-Spotless is configured in the **parent POM** and resolves the header file using:
-
-```
-${maven.multiModuleProjectDirectory}/config/license-header.txt
-```
-
-so children modules pick up the root header correctly.
+> **Do not** hand-format files or hand-edit headers; let Spotless do it. Running `mvn clean install` locally will mutate sources to match the standard.
 
 ### Checkstyle
 
@@ -52,46 +43,15 @@ We keep **Checkstyle** to enforce additional rules. CI fails if formatting or st
 
 * **JDK 17+**
 * **Maven 3.8+**
-* **Git**, **Make**, **Bash**
+* **Git**
 * Optional IDE plugins:
 
-    * IntelliJ: *Google Java Format* plugin (for local editing experience). Spotless remains the source of truth.
-
-### Install the Git Hooks (one-time)
-
-```bash
-make hooks
-```
-
-This calls `scripts/install-git-hooks.sh` which sets `core.hooksPath` to `.githooks` and marks hooks executable.
-
-### Pre-commit Hook Behavior
-
-* Runs only on **staged** `*.java` files.
-* Temporarily stashes unstaged edits (to avoid committing them), runs Spotless, **re-stages** formatted files, then restores the stash.
-* If it reformats something, your commit still proceeds with the updated index.
-
-If something goes wrong:
-
-* Run `make format` to apply formatting to the whole repo.
-* Stage changes and commit again.
-
----
-
-## Make Targets
-
-Common tasks are wrapped in a Makefile:
+  * IntelliJ: *Google Java Format* plugin (for local editing experience). Spotless remains the source of truth.
 
-```text
-make hooks   # Install/enable repo-local git hooks
-make format  # Spotless apply (format + license headers)
-make check   # Spotless check + Checkstyle check
-make verify  # mvn verify (full build)
-make ci      # CI checks (Spotless + Checkstyle, no tests)
-make clean   # mvn clean
-```
+### Local build & formatting
 
-> If `make` complains about a “missing separator”, ensure each command line under a target starts with a **TAB**.
+* Run `mvn clean install` from the repo root. During the build, Spotless **applies** formatting and license headers.
+* Before pushing, run `mvn -DskipTests spotless:check checkstyle:check` to ensure CI will pass.
 
 ---
 
@@ -128,10 +88,10 @@ make clean   # mvn clean
 * Link related issues.
 * Check the box:
 
-    * [ ] `make check` passes locally
-    * [ ] Unit/integration tests updated
-    * [ ] Public API changes documented/Javadoc updated
-    * [ ] No unrelated formatting churn (Spotless should keep this minimal)
+  * [ ] `mvn -DskipTests spotless:check checkstyle:check` passes locally
+  * [ ] Unit/integration tests updated
+  * [ ] Public API changes documented/Javadoc updated
+  * [ ] No unrelated formatting churn (Spotless should keep this minimal)
 
 ---
 
@@ -149,24 +109,23 @@ make clean   # mvn clean
 
 ## License Headers
 
-* Header template lives at: `config/license-header.txt` (root).
-* Spotless inserts or normalizes it automatically.
-* If the copyright line needs updates, edit the template and run `make format`.
+* The license header is defined **inline** in the parent POM under Spotless’ `<licenseHeader>`.
+* To update it, edit the parent POM and run `mvn spotless:apply` to propagate changes.
 
 ---
 
 ## CI
 
 * CI runs `spotless:check` and `checkstyle:check` to ensure consistent formatting and style.
-* Builds fail if formatting or headers drift. Run `make format` locally to fix.
+* Builds fail if formatting or headers drift. Run `mvn spotless:apply` locally to fix.
 
 ---
 
 ## Troubleshooting
 
-* **Hook didn’t run?** Did you run `make hooks` after cloning? Check `git config --get core.hooksPath` prints `.githooks`.
-* **Header file not found?** Ensure Spotless uses the root path via `${maven.multiModuleProjectDirectory}/config/license-header.txt`.
-* **Formatting conflicts with unstaged edits?** The hook stashes them. If a conflict occurs, complete the merge in your working copy, then `git add` and commit again.
+* **Spotless changed files during build?** That’s expected locally. Review `git status`, then stage and commit the updates.
+* **CI red on formatting?** Run `mvn spotless:apply` locally, commit, and push.
+* **Running only a submodule?** Prefer `mvn -pl <module> -am …` from the repo root so parent config (Spotless/Checkstyle) is applied consistently.
 
 ---
 

CONTRIBUTING.md

@@ -8,6 +8,12 @@
     </parent>
     <name>Serverless Workflow :: Examples :: Events</name>
     <artifactId>serverlessworkflow-examples-events</artifactId>
+
+    <properties>
+        <mainClass>events.EventExample</mainClass>
+    </properties>
+
+
     <dependencies>
         <dependency>
             <groupId>io.serverlessworkflow</groupId>
@@ -18,4 +24,12 @@
             <artifactId>slf4j-simple</artifactId>
         </dependency>
     </dependencies>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>exec-maven-plugin</artifactId>
+            </plugin>
+        </plugins>
+    </build>
 </project>

Makefile

@@ -8,6 +8,11 @@
     </parent>
     <artifactId>serverlessworkflow-examples-simpleGet</artifactId>
     <name>Serverless Workflow :: Examples :: SimpleGet</name>
+
+    <properties>
+        <mainClass>io.serverlessworkflow.impl.BlockingExample</mainClass>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>io.serverlessworkflow</groupId>
@@ -30,4 +35,15 @@
             <artifactId>slf4j-simple</artifactId>
         </dependency>
     </dependencies>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>exec-maven-plugin</artifactId>
+                <configuration>
+                    <mainClass>${mainClass}</mainClass>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
 </project>