chore: fix CI by removing examples module; remove *.db files from tests module #941
+43
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts module Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
fjtirado
reviewed
Nov 3, 2025
Collaborator
There was a problem hiding this comment.
I do not get why storing binary file is worse than spawning a new JVM.
Also the DB files were stored on purpose to check backward compatibility with previous DB versions. They are intentionally NOT generated with every run
In my opinion this PR should just contain changes on release.yaml, pom.xml (to not run the examples) and comment main method of DBGenerator.
fjtirado
reviewed
Nov 3, 2025
fjtirado
reviewed
Nov 3, 2025
impl/test/src/test/java/io/serverlessworkflow/impl/test/MvStorePersistenceTest.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Nov 3, 2025
fjtirado
reviewed
Nov 3, 2025
impl/test/src/test/java/io/serverlessworkflow/impl/test/DBGenerator.java
Show resolved
Hide resolved
fjtirado
reviewed
Nov 3, 2025
fjtirado
reviewed
Nov 3, 2025
impl/test/src/test/java/io/serverlessworkflow/impl/test/ForkedDbGen.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Nov 3, 2025
impl/test/src/test/java/io/serverlessworkflow/impl/test/ForkedDbGen.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Nov 3, 2025
impl/test/src/test/java/io/serverlessworkflow/impl/test/MvStorePersistenceTest.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Nov 3, 2025
impl/test/src/test/java/io/serverlessworkflow/impl/test/DBGenerator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
fjtirado
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Correcting the sample workflowset-listen-to-any.yamlso a listen actually waits (not completes immediately due tolisten.any: []).Generating DB samples at test time (under@TempDir) instead of committing binary DB files.Making the restore tests parameterized.Adding deterministic awaits in the DB generator to eliminate race conditions.examplesfrom release mvn command.Follow up:
To check if the desired behavior is to finish the workflow immediately onlisten.to.any: []. I believe that's the desired behavior, but it's worth checking out.Not sure how theDbGeneratorwas working before, since the sample workflow was completed immediately/having a racing condition before suspending/finishing the workflow by listening to anything empty.I created a small/raw/workaround to run the generator on a separate JVM when running the tests to avoid a collision with the file read. It's working pretty good, if you have a better idea (or any changes in the store implementation to avoid this), let me know.