moved validate to constructor and added isValid property

Signed-off-by: Antonio Mendoza Pérez <[email protected]>

Author: antmendoza

src/lib/validation-error.ts

@@ -0,0 +1,3 @@
+export class ValidationError {
+  constructor(readonly message: string) {}
+}

src/lib/workflow-validator.ts

@@ -18,36 +18,33 @@
 import { ValidateFunction } from 'ajv';
 import { Specification } from './definitions';
 import { validators } from './validators';
+import { ValidationError } from './validation-error';
 
 export class WorkflowValidator {
   /** The validation errors after running validate(), if any */
   errors: ValidationError[] | never[] = [];
-  /** The validate function */
-  private validateFn: ValidateFunction<Specification.Workflow>;
+
+  /** Whether the workflow is valid or not */
+  isValid: boolean;
 
   /**
    * Creates a new WorkflowValidator for the provided workflow
    * @param {Workflow} workflow The workflow to validate
    */
   constructor(private workflow: Specification.Workflow) {
-    this.validateFn = validators.get('Workflow') as ValidateFunction<Specification.Workflow>;
+    this.validate();
   }
 
   /**
    * Validates the workflow, populates the errors if any
-   * @returns {boolean} If the workflow is valid or not
    */
-  validate(): boolean {
-    const isValid = this.validateFn(this.workflow);
-    if (this.validateFn.errors) {
-      this.errors = this.validateFn.errors.map(
+  private validate(): void {
+    const validateFn = validators.get('Workflow') as ValidateFunction<Specification.Workflow>;
+    this.isValid = validateFn(this.workflow);
+    if (validateFn.errors) {
+      this.errors = validateFn.errors.map(
         (error) => new ValidationError(`invalid: ${error.instancePath} | ${error.schemaPath} | ${error.message}`)
       );
     }
-    return isValid;
   }
 }
-
-export class ValidationError {
-  constructor(readonly message: string) {}
-}

src/serverless-workflow-sdk.ts

@@ -15,6 +15,7 @@
  *
  */
 
+export * from './lib/validation-error';
 export * from './lib/workflow-converter';
 export * from './lib/workflow-validator';
 export * from './lib/validators';

tests/workflow-validator.spec.ts

@@ -30,9 +30,7 @@ describe('workflow-validator', () => {
     } as Workflow;
 
     const workflowValidator = new WorkflowValidator(workflow);
-    expect(workflowValidator.errors.length).toBe(0);
-
-    workflowValidator.validate();
+    expect(workflowValidator.isValid).toBeFalsy('Expected isValid to be false');
     expect(workflowValidator.errors.length).toBe(1);
     expect(workflowValidator.errors[0].constructor === ValidationError).toBeTruthy(
       'Expected errors to be instance of ValidationError'
@@ -57,9 +55,9 @@ describe('workflow-validator', () => {
         },
       ],
     } as Workflow;
-    
+
     const workflowValidator = new WorkflowValidator(workflow);
-    workflowValidator.validate();
     expect(workflowValidator.errors.length).toBe(0);
+    expect(workflowValidator.isValid).toBeTruthy('Expected isValid to be true');
   });
 });