Skip to content

Commit 8d59c68

Browse files
committed
Rolled back defaults
- removed default value handling in builders Signed-off-by: JBBianchi <[email protected]>
1 parent a91c4f3 commit 8d59c68

31 files changed

+53
-198
lines changed

src/lib/builders/callbackstate-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { validate } from '../utils';
2727
function callbackstateBuildingFn(data: Specification.Callbackstate): () => Specification.Callbackstate {
2828
return () => {
2929
data.type = 'callback';
30-
data.usedForCompensation = data.usedForCompensation || false;
3130
validate('Callbackstate', data);
3231
return data;
3332
};

src/lib/builders/databasedswitch-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { validate } from '../utils';
2727
function databasedswitchBuildingFn(data: Specification.Databasedswitch): () => Specification.Databasedswitch {
2828
return () => {
2929
data.type = 'switch';
30-
data.usedForCompensation = data.usedForCompensation || false;
3130
validate('Databasedswitch', data);
3231
return data;
3332
};

src/lib/builders/delaystate-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { validate } from '../utils';
2727
function delaystateBuildingFn(data: Specification.Delaystate): () => Specification.Delaystate {
2828
return () => {
2929
data.type = 'delay';
30-
data.usedForCompensation = data.usedForCompensation || false;
3130
validate('Delaystate', data);
3231
return data;
3332
};

src/lib/builders/end-builder.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ import { validate } from '../utils';
2626
*/
2727
function endBuildingFn(data: Specification.End): () => Specification.End {
2828
return () => {
29-
if (typeof data !== typeof true) {
30-
(data as any).terminate = (data as any).terminate || false;
31-
(data as any).compensate = (data as any).compensate || false;
32-
}
3329
validate('End', data);
3430
return data;
3531
};

src/lib/builders/eventbasedswitch-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { validate } from '../utils';
2727
function eventbasedswitchBuildingFn(data: Specification.Eventbasedswitch): () => Specification.Eventbasedswitch {
2828
return () => {
2929
data.type = 'switch';
30-
data.usedForCompensation = data.usedForCompensation || false;
3130
validate('Eventbasedswitch', data);
3231
return data;
3332
};

src/lib/builders/eventstate-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { validate } from '../utils';
2727
function eventstateBuildingFn(data: Specification.Eventstate): () => Specification.Eventstate {
2828
return () => {
2929
data.type = 'event';
30-
if (data.exclusive == null) data.exclusive = true;
3130
validate('Eventstate', data);
3231
return data;
3332
};

src/lib/builders/exectimeout-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import { validate } from '../utils';
2626
*/
2727
function exectimeoutBuildingFn(data: Specification.Exectimeout): () => Specification.Exectimeout {
2828
return () => {
29-
data.interrupt = data.interrupt || false;
3029
validate('Exectimeout', data);
3130
return data;
3231
};

src/lib/builders/foreachstate-builder.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ import { validate } from '../utils';
2727
function foreachstateBuildingFn(data: Specification.Foreachstate): () => Specification.Foreachstate {
2828
return () => {
2929
data.type = 'foreach';
30+
31+
//FIXME https://github.com/serverlessworkflow/sdk-typescript/issues/95
32+
3033
data.usedForCompensation = data.usedForCompensation || false;
3134
validate('Foreachstate', data);
3235
return data;

src/lib/builders/injectstate-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { validate } from '../utils';
2727
function injectstateBuildingFn(data: Specification.Injectstate): () => Specification.Injectstate {
2828
return () => {
2929
data.type = 'inject';
30-
data.usedForCompensation = data.usedForCompensation || false;
3130
validate('Injectstate', data);
3231
return data;
3332
};

src/lib/builders/onevents-builder.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import { validate } from '../utils';
2626
*/
2727
function oneventsBuildingFn(data: Specification.Onevents): () => Specification.Onevents {
2828
return () => {
29-
data.actionMode = data.actionMode || 'sequential';
3029
validate('Onevents', data);
3130
return data;
3231
};

0 commit comments

Comments
 (0)