refactor: update testing to more idiomatic JS

Signed-off-by: Matthias Pichler <[email protected]>

Author: matthias-pichler

.ci/validation/src/index.test.ts

@@ -16,22 +16,22 @@
 
 import { SWSchemaValidator } from "./index";
 import fs from "node:fs";
-import { join } from "node:path";
+import path from "node:path";
 
 SWSchemaValidator.prepareSchemas();
 
 const examplePath = "../../../examples";
 
 describe(`Verify every example in the repository`, () => {
-  fs.readdirSync(join(__dirname, examplePath), {
+  fs.readdirSync(path.join(__dirname, examplePath), {
     encoding: SWSchemaValidator.defaultEncoding,
     recursive: false,
     withFileTypes: true,
   }).forEach((file) => {
     if (file.isFile() && file.name.endsWith(".yaml")) {
       test(`Example ${file.name}`, () => {
         const workflow = SWSchemaValidator.toJSON(
-          join(__dirname, `${examplePath}/${file.name}`)
+          path.join(__dirname, `${examplePath}/${file.name}`)
         );
         const results = SWSchemaValidator.validateSchema(workflow);
         if (results?.errors != null) {

.ci/validation/src/index.ts

@@ -17,7 +17,7 @@
 import fs from "node:fs";
 import Ajv from "ajv";
 import addFormats from "ajv-formats";
-import { join } from "node:path";
+import path from "node:path";
 import yaml = require("js-yaml");
 
 export module SWSchemaValidator {
@@ -30,7 +30,7 @@ export module SWSchemaValidator {
   export const defaultEncoding = "utf-8";
 
   export function prepareSchemas() {
-    fs.readdirSync(join(__dirname, schemaPath), {
+    fs.readdirSync(path.join(__dirname, schemaPath), {
       encoding: defaultEncoding,
       recursive: false,
       withFileTypes: true,
@@ -41,20 +41,20 @@ export module SWSchemaValidator {
     });
   }
 
-  function syncReadSchema(filename: string) {
-    return toJSON(join(__dirname, `${schemaPath}/${filename}`));
+  function syncReadSchema(filename: string): any {
+    return toJSON(path.join(__dirname, `${schemaPath}/${filename}`));
   }
 
-  export function toJSON(filename: string) {
+  export function toJSON(filename: string): any {
     const yamlObj = yaml.load(fs.readFileSync(filename, defaultEncoding), {
       json: true,
     });
-    return JSON.parse(JSON.stringify(yamlObj, null, 2));
+    return structuredClone(yamlObj);
   }
 
-  export function validateSchema(workflow: JSON) {
+  export function validateSchema(workflow: Record<string, unknown>) {
     const validate = ajv.getSchema(workflowSchemaId);
-    if (validate != undefined) {
+    if (validate) {
       const isValid = validate(workflow);
       return {
         valid: isValid,