Skip to content

Commit 4431d8c

Browse files
authored
Adding subflow action version property (#342)
* Adding subflow action version property Signed-off-by: Tihomir Surdilovic <[email protected]> * update per comments Signed-off-by: Tihomir Surdilovic <[email protected]> * updates per reviews Signed-off-by: Tihomir Surdilovic <[email protected]> * updates Signed-off-by: Tihomir Surdilovic <[email protected]> * small typo Signed-off-by: Tihomir Surdilovic <[email protected]> * typo fix Signed-off-by: Tihomir Surdilovic <[email protected]> * updates per comments - specVersion and updated versioning section Signed-off-by: Tihomir Surdilovic <[email protected]> * updates per discussions Signed-off-by: Tihomir Surdilovic <[email protected]> * fixes text Signed-off-by: Tihomir Surdilovic <[email protected]> * updated roadmap Signed-off-by: Tihomir Surdilovic <[email protected]>
1 parent e63f665 commit 4431d8c

File tree

11 files changed

+164
-24
lines changed

11 files changed

+164
-24
lines changed

comparisons/comparison-argo.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ spec:
7777
id: hello-world-parameters
7878
name: Hello World with parameters
7979
version: '1.0'
80+
specVersion: '0.6'
8081
start: whalesay
8182
functions:
8283
- name: whalesayimage
@@ -155,6 +156,7 @@ spec:
155156
id: hello-hello-hello
156157
name: Multi Step Hello
157158
version: '1.0'
159+
specVersion: '0.6'
158160
start: hello1
159161
functions:
160162
- name: whalesayimage
@@ -256,6 +258,7 @@ spec:
256258
id: dag-diamond-
257259
name: DAG Diamond Example
258260
version: '1.0'
261+
specVersion: '0.6'
259262
start: A
260263
functions:
261264
- name: echo
@@ -374,6 +377,7 @@ spec:
374377
id: scripts-bash-
375378
name: Scripts and Results Example
376379
version: '1.0'
380+
specVersion: '0.6'
377381
start: generate
378382
functions:
379383
- name: gen-random-int-bash
@@ -469,6 +473,7 @@ spec:
469473
id: loops-
470474
name: Loop over data example
471475
version: '1.0'
476+
specVersion: '0.6'
472477
start: injectdata
473478
functions:
474479
- name: whalesay
@@ -563,6 +568,7 @@ spec:
563568
id: coinflip-
564569
name: Conditionals Example
565570
version: '1.0'
571+
specVersion: '0.6'
566572
start: flip-coin
567573
functions:
568574
- name: flip-coin-function
@@ -655,6 +661,7 @@ spec:
655661
id: retry-backoff-
656662
name: Retry Example
657663
version: '1.0'
664+
specVersion: '0.6'
658665
start: retry-backoff
659666
functions:
660667
- name: fail-function
@@ -744,6 +751,7 @@ spec:
744751
id: coinflip-recursive-
745752
name: Recursion Example
746753
version: '1.0'
754+
specVersion: '0.6'
747755
start: flip-coin-state
748756
functions:
749757
- name: heads-function
@@ -853,6 +861,7 @@ spec:
853861
id: exit-handlers-
854862
name: Exit/Error Handling Example
855863
version: '1.0'
864+
specVersion: '0.6'
856865
start: intentional-fail-state
857866
functions:
858867
- name: intentional-fail-function

comparisons/comparison-bpmn.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ For this reason, the event, function, retry, and data mapping defined in the ass
5353
id: processfile
5454
name: Process File Workflow
5555
version: '1.0'
56+
specVersion: '0.6'
5657
start: Process File
5758
states:
5859
- name: Process File
@@ -88,6 +89,7 @@ functions:
8889
id: processapplication
8990
name: Process Application
9091
version: '1.0'
92+
specVersion: '0.6'
9193
start: ProcessNewApplication
9294
states:
9395
- name: ProcessNewApplication
@@ -141,6 +143,7 @@ events:
141143
id: simplecompensation
142144
name: Simple Compensation
143145
version: '1.0'
146+
specVersion: '0.6'
144147
start: Step 1
145148
states:
146149
- name: Step 1
@@ -201,6 +204,7 @@ functions:
201204
id: errorwithretries
202205
name: Error Handling With Retries Workflow
203206
version: '1.0'
207+
specVersion: '0.6'
204208
start: Make Coffee
205209
states:
206210
- name: Make Coffee
@@ -258,6 +262,7 @@ functions:
258262
id: executiontimeout
259263
name: Execution Timeout Workflow
260264
version: '1.0'
265+
specVersion: '0.6'
261266
start: Purchase Parts
262267
execTimeout:
263268
duration: PT7D
@@ -310,6 +315,7 @@ functions:
310315
id: foreachWorkflow
311316
name: ForEach State Workflow
312317
version: '1.0'
318+
specVersion: '0.6'
313319
start: ForEachItem
314320
states:
315321
- name: ForEachItem
@@ -348,6 +354,7 @@ a starting "operation" state transitioning to an "event" state which waits for t
348354
id: subflowloop
349355
name: SubFlow Loop Workflow
350356
version: '1.0'
357+
specVersion: '0.6'
351358
start: SubflowRepeat
352359
states:
353360
- name: SubflowRepeat
@@ -397,6 +404,7 @@ control-flow logic to check email and make a decision to reply to it or wait an
397404
id: approvereport
398405
name: Approve Report Workflow
399406
version: '1.0'
407+
specVersion: '0.6'
400408
start: Approve Report
401409
states:
402410
- name: Approve Report
@@ -459,6 +467,7 @@ functions:
459467
id: eventdecision
460468
name: Event Decision workflow
461469
version: '1.0'
470+
specVersion: '0.6'
462471
start: A
463472
states:
464473
- name: A

comparisons/comparison-brigade.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ function exec(e, p) {
6565
id: greeting
6666
name: Greeting Workflow
6767
version: '1.0'
68+
specVersion: '0.6'
6869
start: GreetingState
6970
events:
7071
- name: execEvent
@@ -144,6 +145,7 @@ async function exec(e, p) {
144145
id: greetingwitherrorcheck
145146
name: Greeting Workflow With Error Check
146147
version: '1.0'
148+
specVersion: '0.6'
147149
start: GreetingState
148150
events:
149151
- name: execEvent
@@ -227,6 +229,7 @@ events.on("push", () => {
227229
id: multieventworkflow
228230
name: Multiple Events Workflow
229231
version: '1.0'
232+
specVersion: '0.6'
230233
start: GreetingState
231234
events:
232235
- name: execEvent
@@ -311,6 +314,7 @@ events.on("exec", () => {
311314
id: groupActionsWorkflow
312315
name: Group Actions Workflow
313316
version: '1.0'
317+
specVersion: '0.6'
314318
start: FirstGreetGroup
315319
events:
316320
- name: execEvent
@@ -389,6 +393,7 @@ events.on("exec", (e, p) => {
389393
id: eventDataWorkflow
390394
name: Event Data Workflow
391395
version: '1.0'
396+
specVersion: '0.6'
392397
start: LogEventData
393398
events:
394399
- name: execEvent
@@ -464,6 +469,7 @@ events.on("exec", (e, p) => {
464469
id: actionResultsWorkflow
465470
name: Action Results Workflow
466471
version: '1.0'
472+
specVersion: '0.6'
467473
start: ExecActionsAndStoreResults
468474
events:
469475
- name: execEvent
@@ -554,6 +560,7 @@ events.on("next", (e) => {
554560
id: eventDataWorkflow
555561
name: Event Data Workflow
556562
version: '1.0'
563+
specVersion: '0.6'
557564
start: ExecEventState
558565
events:
559566
- name: execEvent

comparisons/comparison-cadence.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ public class TripBookingWorkflowImpl implements TripBookingWorkflow {
8383
id: tripbookingwithcompensation
8484
name: Trip Booking With Compensation
8585
version: '1.0'
86+
specVersion: '0.6'
8687
start: BookTrip
8788
states:
8889
- name: BookTrip
@@ -191,6 +192,7 @@ public class FileProcessingWorkflowImpl implements FileProcessingWorkflow {
191192
id: fileprocessingwithretries
192193
name: File Processing Workflow With Retries
193194
version: '1.0'
195+
specVersion: '0.6'
194196
start: ProcessAndUpload
195197
states:
196198
- name: ProcessAndUpload
@@ -295,6 +297,7 @@ public static class GreetingWorkflowImpl implements GreetingWorkflow {
295297
id: subflowgreeting
296298
name: SubFlow Greeting Workflow
297299
version: '1.0'
300+
specVersion: '0.6'
298301
start: GreetingSubFlow
299302
states:
300303
- name: GreetingSubFlow

comparisons/comparison-google-cloud-workflows.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ languages.
8686
{
8787
"id": "greetingwithargs",
8888
"name": "Greeting With Args",
89+
"specVersion": "0.6",
8990
"start": "Set Output",
9091
"states": [
9192
{
@@ -194,6 +195,7 @@ instance is created. See the Serverless Workflow ["Workflow Data"](../specificat
194195
"id": "concatarray",
195196
"name": "Concatenating array values",
196197
"start": "DoConcat",
198+
"specVersion": "0.6",
197199
"states": [
198200
{
199201
"name": "DoConcat",
@@ -283,6 +285,7 @@ array values, however it would just unnecessarily complicate things.
283285
{
284286
"id": "stopcomputeengine",
285287
"name": "Stop Compute Engine",
288+
"specVersion": "0.6",
286289
"start": "DoStop",
287290
"states": [
288291
{
@@ -413,6 +416,7 @@ as service invocations, where as Google Workflow uses the "call" keyword.
413416
{
414417
"id": "publishtotopicwitherrorhandling",
415418
"name": "Publish To Topic With Error Handling",
419+
"specVersion": "0.6",
416420
"start": "DoPublish",
417421
"states": [
418422
{
@@ -576,6 +580,7 @@ to interested parties via events (CloudEvents specification format), which we ar
576580
"id": "errorhandlingwithretries",
577581
"name": "Error Handling with Retries",
578582
"start": "ReadItem",
583+
"specVersion": "0.6",
579584
"states": [
580585
{
581586
"name": "ReadItem",

comparisons/comparison-temporal.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ public class HelloActivity {
132132
{
133133
"id": "HelloActivityRetry",
134134
"name": "Hello Activity Workflow",
135-
"version": "1.0",
135+
"version": "1.0",
136+
"specVersion": "0.6",
136137
"start": "GreetingState",
137138
"states": [
138139
{
@@ -268,6 +269,7 @@ public class HelloActivity {
268269
"id": "HelloCron",
269270
"name": "Hello Activity with Cron Workflow",
270271
"version": "1.0",
272+
"specVersion": "0.6",
271273
"start": {
272274
"stateName": "GreetingState",
273275
"schedule": {
@@ -452,6 +454,7 @@ public class HelloActivity {
452454
"id": "HelloSaga",
453455
"name": "Hello SAGA compensation Workflow",
454456
"version": "1.0",
457+
"specVersion": "0.6",
455458
"start": "ExecuteState",
456459
"states": [
457460
{
@@ -608,6 +611,7 @@ public class HelloActivityRetry {
608611
"id": "HelloActivityRetry",
609612
"name": "Hello Activity with Retries Workflow",
610613
"version": "1.0",
614+
"specVersion": "0.6",
611615
"start": "GreetingState",
612616
"states": [
613617
{

0 commit comments

Comments
 (0)