Move start definition to top-level workflow properties (#266)

Signed-off-by: Tihomir Surdilovic <[email protected]>

Author: Tihomir Surdilovic

comparisons/comparison-argo.md

@@ -77,6 +77,7 @@ spec:
 id: hello-world-parameters
 name: Hello World with parameters
 version: '1.0'
+start: whalesay
 functions:
 - name: whalesayimage
   metadata:
@@ -85,7 +86,6 @@ functions:
 states:
 - name: whalesay
   type: operation
-  start: true
   actions:
   - functionRef:
       refName: whalesayimage
@@ -155,6 +155,7 @@ spec:
 id: hello-hello-hello
 name: Multi Step Hello
 version: '1.0'
+start: hello1
 functions:
 - name: whalesayimage
   metadata:
@@ -163,7 +164,6 @@ functions:
 states:
 - name: hello1
   type: operation
-  start: true
   actions:
   - functionRef:
       refName: whalesayimage
@@ -256,6 +256,7 @@ spec:
 id: dag-diamond-
 name: DAG Diamond Example
 version: '1.0'
+start: A
 functions:
 - name: echo
   metadata:
@@ -264,7 +265,6 @@ functions:
 states:
 - name: A
   type: operation
-  start: true
   actions:
   - functionRef:
       refName: echo
@@ -290,7 +290,6 @@ states:
   transition: D
 - name: D
   type: operation
-  start: true
   actions:
   - functionRef:
       refName: echo
@@ -375,6 +374,7 @@ spec:
 id: scripts-bash-
 name: Scripts and Results Example
 version: '1.0'
+start: generate
 functions:
 - name: gen-random-int-bash
   metadata:
@@ -401,7 +401,6 @@ functions:
 states:
 - name: generate
   type: operation
-  start: true
   actions:
   - functionRef: gen-random-int-bash
     actionDataFilter:
@@ -470,6 +469,7 @@ spec:
 id: loops-
 name: Loop over data example
 version: '1.0'
+start: injectdata
 functions:
 - name: whalesay
   metadata:
@@ -478,7 +478,6 @@ functions:
 states:
 - name: injectdata
   type: inject
-  start: true
   data:
     greetings:
     - hello world
@@ -564,6 +563,7 @@ spec:
 id: coinflip-
 name: Conditionals Example
 version: '1.0'
+start: flip-coin
 functions:
 - name: flip-coin-function
   metadata:
@@ -578,7 +578,6 @@ functions:
 states:
 - name: flip-coin
   type: operation
-  start: true
   actions:
   - functionRef: flip-coin-function
     actionDataFilter:
@@ -656,6 +655,7 @@ spec:
 id: retry-backoff-
 name: Retry Example
 version: '1.0'
+start: retry-backoff
 functions:
 - name: fail-function
   metadata:
@@ -670,7 +670,6 @@ retries:
 states:
 - name: retry-backoff
   type: operation
-  start: true
   actions:
   - functionRef:
       refName: flip-coin-function
@@ -745,6 +744,7 @@ spec:
 id: coinflip-recursive-
 name: Recursion Example
 version: '1.0'
+start: flip-coin-state
 functions:
 - name: heads-function
   metadata:
@@ -758,7 +758,6 @@ functions:
 states:
 - name: flip-coin-state
   type: operation
-  start: true
   actions:
   - functionRef: flip-coin-function
     actionDataFilter:
@@ -854,6 +853,7 @@ spec:
 id: exit-handlers-
 name: Exit/Error Handling Example
 version: '1.0'
+start: intentional-fail-state
 functions:
 - name: intentional-fail-function
   metadata:
@@ -870,7 +870,6 @@ functions:
 states:
 - name: intentional-fail-state
   type: operation
-  start: true
   actions:
   - functionRef:
       refName: intentional-fail-function

comparisons/comparison-bpmn.md

@@ -52,10 +52,10 @@ For this reason, the event, function, retry, and data mapping defined in the ass
 id: processfile
 name: Process File Workflow
 version: '1.0'
+start: Process File
 states:
 - name: Process File
   type: operation
-  start: true
   actions:
   - functionRef: processFile
   end: true
@@ -87,10 +87,10 @@ functions:
 id: processapplication
 name: Process Application
 version: '1.0'
+start: ProcessNewApplication
 states:
 - name: ProcessNewApplication
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - ApplicationReceivedEvent
@@ -140,9 +140,9 @@ events:
 id: simplecompensation
 name: Simple Compensation
 version: '1.0'
+start: Step 1
 states:
 - name: Step 1
-  start: true
   type: operation
   actions:
   - functionRef: step1function
@@ -200,9 +200,9 @@ functions:
 id: errorwithretries
 name: Error Handling With Retries Workflow
 version: '1.0'
+start: Make Coffee
 states:
 - name: Make Coffee
-  start: true
   type: operation
   actions:
   - functionRef: makeCoffee
@@ -257,13 +257,13 @@ functions:
 id: executiontimeout
 name: Execution Timeout Workflow
 version: '1.0'
+start: Purchase Parts
 execTimeout:
   interval: PT7D
   interrupt: true
   runBefore: Handle timeout
 states:
 - name: Purchase Parts
-  start: true
   type: operation
   actions:
   - functionRef: purchasePartsFunction
@@ -309,10 +309,10 @@ functions:
 id: subflowloop
 name: SubFlow Repeat workflow
 version: '1.0'
+start: SubflowRepeat
 states:
 - name: SubflowRepeat
   type: subflow
-  start: true
   workflowId: dosomethingandwaitformessage
   repeat:
     max: 10
@@ -345,10 +345,10 @@ a starting "operation" state transitioning to an "event" state that waits for th
 id: approvereport
 name: Approve Report Workflow
 version: '1.0'
+start: Approve Report
 states:
 - name: Approve Report
   type: callback
-  start: true
   action:
     functionRef: managerDecideOnReport
   eventRef: ReportDecisionMadeEvent
@@ -407,10 +407,10 @@ functions:
 id: eventdecision
 name: Event Decision workflow
 version: '1.0'
+start: A
 states:
 - name: A
   type: subflow
-  start: true
   workflowId: asubflowid
   transition: Event Decision
 - name: Event Decision

comparisons/comparison-brigade.md

@@ -65,6 +65,7 @@ function exec(e, p) {
 id: greeting
 name: Greeting Workflow
 version: '1.0'
+start: GreetingState
 events:
 - name: execEvent
   type: exec
@@ -78,7 +79,6 @@ functions:
 states:
 - name: GreetingState
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - execEvent
@@ -144,6 +144,7 @@ async function exec(e, p) {
 id: greetingwitherrorcheck
 name: Greeting Workflow With Error Check
 version: '1.0'
+start: GreetingState
 events:
 - name: execEvent
   type: exec
@@ -157,7 +158,6 @@ functions:
 states:
 - name: GreetingState
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - execEvent
@@ -227,6 +227,7 @@ events.on("push", () => {
 id: multieventworkflow
 name: Multiple Events Workflow
 version: '1.0'
+start: GreetingState
 events:
 - name: execEvent
   type: exec
@@ -238,7 +239,6 @@ functions:
 states:
 - name: GreetingState
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - execEvent
@@ -311,6 +311,7 @@ events.on("exec", () => {
 id: groupActionsWorkflow
 name: Group Actions Workflow
 version: '1.0'
+start: FirstGreetGroup
 events:
 - name: execEvent
   type: exec
@@ -322,7 +323,6 @@ functions:
 states:
 - name: FirstGreetGroup
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - execEvent
@@ -389,6 +389,7 @@ events.on("exec", (e, p) => {
 id: eventDataWorkflow
 name: Event Data Workflow
 version: '1.0'
+start: LogEventData
 events:
 - name: execEvent
   type: exec
@@ -398,7 +399,6 @@ functions:
 states:
 - name: LogEventData
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - execEvent
@@ -464,6 +464,7 @@ events.on("exec", (e, p) => {
 id: actionResultsWorkflow
 name: Action Results Workflow
 version: '1.0'
+start: ExecActionsAndStoreResults
 events:
 - name: execEvent
   type: exec
@@ -479,7 +480,6 @@ functions:
 states:
 - name: ExecActionsAndStoreResults
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - execEvent
@@ -554,6 +554,7 @@ events.on("next", (e) => {
 id: eventDataWorkflow
 name: Event Data Workflow
 version: '1.0'
+start: ExecEventState
 events:
 - name: execEvent
   type: exec
@@ -566,7 +567,6 @@ functions:
 states:
 - name: ExecEventState
   type: event
-  start: true
   onEvents:
   - eventRefs:
     - execEvent

comparisons/comparison-cadence.md

@@ -83,10 +83,10 @@ public class TripBookingWorkflowImpl implements TripBookingWorkflow {
 id: tripbookingwithcompensation
 name: Trip Booking With Compensation
 version: '1.0'
+start: BookTrip
 states:
 - name: BookTrip
   type: operation
-  start: true
   compensatedBy: CancelTrip
   actions:
   - functionRef: reservecarfunction
@@ -191,10 +191,10 @@ public class FileProcessingWorkflowImpl implements FileProcessingWorkflow {
 id: fileprocessingwithretries
 name: File Processing Workflow With Retries
 version: '1.0'
+start: ProcessAndUpload
 states:
 - name: ProcessAndUpload
   type: operation
-  start: true
   actions:
   - functionRef:
       refName: processfilefunction
@@ -295,11 +295,11 @@ public static class GreetingWorkflowImpl implements GreetingWorkflow {
 id: subflowgreeting
 name: SubFlow Greeting Workflow
 version: '1.0'
+start: GreetingSubFlow
 states:
 - name: GreetingSubFlow
   type: subflow
   workflowId: subflowgreet
-  start: true
   waitForCompletion: false
   end: true
 functions: