Skip to content

Commit fdb8141

Browse files
Changing templates and PR opening requirements (#638)
* Changing templates and PR opening requirements Signed-off-by: Ricardo Zanini <[email protected]> * Fix a few typos and spelling Signed-off-by: Ricardo Zanini <[email protected]>
1 parent d29dfdf commit fdb8141

File tree

8 files changed

+102
-45
lines changed

8 files changed

+102
-45
lines changed

.github/ISSUE_TEMPLATE/bug-report.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,21 @@ labels: kind/bug
55

66
---
77

8-
**What happened**:
8+
<!--
9+
Sometimes can be hard to describe a "bug" in a specification. So, before opening
10+
a Bug Report, please consider opening a discussion using the "Discussions" tab.
11+
The community will be more than happy to clarify a concern you might have.
912
10-
**What you expected to happen**:
13+
If you see a typo, spelling error, or formatting issue in our docs, please open
14+
a PR.
15+
-->
1116

12-
**How to reproduce it**:
17+
**What seems off**:
18+
19+
**What you expected to be**:
1320

1421
**Anything else we need to know?**:
1522

1623
**Environment**:
17-
- Specification version used:
24+
25+
- Specification version used:

.github/ISSUE_TEMPLATE/enhancement.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,18 @@ labels: kind/feature
55

66
---
77

8+
<!--
9+
Enhancements in a specification are not always easy to describe at first glance,
10+
requiring some discussions with other groups before reaching a conclusion.
11+
12+
Because of this, we kindly ask you to consider opening a discussion using the
13+
"Discussions" tab. The community will be more than happy to discuss your
14+
enhancement proposal there.
15+
16+
If you see a typo, spelling error, or formatting issue in our docs, please open
17+
a PR.
18+
-->
19+
820
**What would you like to be added**:
921

10-
**Why is this needed**:
22+
**Why is this needed**:

.github/ISSUE_TEMPLATE/new-extension.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ labels: kind/feature
55

66
---
77

8+
<!--
9+
We are more than thrilled to accept a new extension!
10+
11+
But before that, have you considered starting a discussion with other
12+
contributors using the "Discussions" tab?
13+
-->
14+
815
**Describe the extension you would like to be added**:
916

10-
**What is the main purpose of the extension**:
17+
**What is the main purpose of the extension**:

.github/ISSUE_TEMPLATE/question.md

Lines changed: 0 additions & 8 deletions
This file was deleted.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
1+
<!--
2+
PLEASE READ THIS BEFORE SUBMITTING A PR!
3+
4+
Other than typos, spelling, or formatting problems in our docs, consider first opening an ISSUE or a DISCUSSION.
5+
6+
Enhancements or bugs in a specification are not always easy to describe at first glance, requiring some discussions with other contributors before reaching a conclusion.
7+
8+
We kindly ask you to consider opening a discussion or an issue using the Github tab menu above. The community will be more than happy to discuss your proposals there.
9+
-->
10+
111
**Many thanks for submitting your Pull Request :heart:!**
212

3-
**Please specify parts this PR updates:**
13+
**Please specify parts of this PR update:**
414

515
- [ ] Specification
616
- [ ] Schema
@@ -12,8 +22,13 @@
1222
- [ ] TCK
1323
- [ ] Other
1424

25+
**Discussion or Issue link**:
26+
<!-- Please consider opening a dicussion or issue for bugs or enhancements. You can ignore this field if this is a typo or spelling fix. -->
27+
1528
**What this PR does / why we need it**:
29+
<!-- Brief description of your PR / Short summary of the discussion or issue -->
1630

1731
**Special notes for reviewers**:
1832

19-
**Additional information (if needed):**
33+
**Additional information:**
34+
<!-- Optional -->

GOVERNANCE.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ is the most interesting or fun.
2121
## Reviewers
2222

2323
A reviewer is a core role within the project.
24-
They share in reviewing issues and pull requests. Their pull request approvals
24+
They share in reviewing issues and pull requests. Their pull request approvals
2525
are needed to merge a large code change into the project.
2626

2727
## Adding maintainers
@@ -57,9 +57,10 @@ becomes a maintainer once the pull request is merged.
5757

5858
## Subprojects
5959

60-
Serverless Workflow subprojects all culminate in officially supported and maintained releases
61-
of the specification.
62-
All subprojects must adhere to [CNCF Code of Conduct](https://github.com/cncf/foundation/blob/master/code-of-conduct.md)
60+
Serverless Workflow subprojects all culminate in officially supported and
61+
maintained releases of the specification.
62+
All subprojects must adhere to
63+
[CNCF Code of Conduct](https://github.com/cncf/foundation/blob/master/code-of-conduct.md)
6364
as well as this governance document.
6465

6566
### Adding core subprojects
@@ -127,12 +128,13 @@ of the pull request and which areas of the project it affects.
127128
## I'm a maintainer. Should I make pull requests too?
128129

129130
Yes. Nobody should ever push to master directly. All changes should be
130-
made through a pull request.
131+
made through a pull request. Please see the [Contributing](contributing.md)
132+
document for more information about opening pull requests.
131133

132134
## Conflict Resolution
133135

134136
If you have a technical dispute that you feel has reached an impasse with a
135137
subset of the community, any contributor may open an issue, specifically
136138
calling for a resolution vote of the current core maintainers to resolve the dispute.
137139
The same voting quorums required (2/3) for adding and removing maintainers
138-
will apply to conflict resolution.
140+
will apply to conflict resolution.

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[<img src="http://img.shields.io/badge/web-serverlessworkflow.io-red?style=social&logo=google-chrome">](https://serverlessworkflow.io/)
55
[<img src="https://img.shields.io/twitter/follow/CNCFWorkflow?style=social">](https://twitter.com/CNCFWorkflow)
66

7-
## About
7+
## About
88

99
CNCF Serverless Workflow defines a vendor-neutral, open-source, and fully community-driven
1010
ecosystem for defining and running DSL-based workflows that target the Serverless technology domain.</h3>
@@ -16,7 +16,7 @@ This project is composed of:
1616
* [Workflow runtimes](#runtimes) supporting the specification
1717
* Developer [tooling support](#tooling) for writing DSL-based workflows
1818

19-
CNCF Serverless Workflow is hosted by the [Cloud Native Computing Foundation (CNCF)](https://www.cncf.io/) and was approved as a
19+
CNCF Serverless Workflow is hosted by the [Cloud Native Computing Foundation (CNCF)](https://www.cncf.io/) and was approved as a
2020
Cloud Native Sandbox level project on July 14, 2020.
2121

2222
## Table of Contents
@@ -27,10 +27,10 @@ Cloud Native Sandbox level project on July 14, 2020.
2727
- [SDKs](#SDKs)
2828
- [Tooling](#Tooling)
2929
- [Community](#Community)
30-
- [Communication](#Communication)
31-
- [Code of Conduct](#Code-of-Conduct)
32-
- [Meetings](#Meetings)
33-
- [Meeting Minutes](#Meeting-Minutes)
30+
- [Communication](#Communication)
31+
- [Code of Conduct](#Code-of-Conduct)
32+
- [Meetings](#Meetings)
33+
- [Meeting Minutes](#Meeting-Minutes)
3434
- [Repository Structure](#Repository-Structure)
3535
- [Support](#Support)
3636

contributing.md

Lines changed: 38 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,42 @@ well as the guidelines we follow for how our documents are formatted.
1111

1212
## Reporting an Issue
1313

14-
To report an issue, or to suggest an idea for a change that you haven't had time
15-
to write-up yet, open an [issue](https://github.com/serverlessworkflow/specification/issues). It
16-
is best to check our existing
17-
[issues](https://github.com/serverlessworkflow/specification/issues) first to see if a similar
18-
one has already been opened and discussed.
14+
If you have a question, consider opening a
15+
[discussion](https://github.com/serverlessworkflow/specification/discussions).
16+
17+
To report an issue or to suggest an idea for a change that you haven't had time
18+
to write up yet, open an
19+
[issue](https://github.com/serverlessworkflow/specification/issues). It is best
20+
to check our existing
21+
[issues](https://github.com/serverlessworkflow/specification/issues) first to
22+
see if a similar one has already been opened and discussed.
1923

2024
## Suggesting a Change
2125

22-
To suggest a change to this repository, submit a
23-
[pull request](https://github.com/serverlessworkflow/specification/pulls) (PR) with the complete
24-
set of changes you'd like to see. See the
26+
Enhancements or bugs in a specification are not always easy to describe at first
27+
glance, requiring some discussions with other contributors before reaching a
28+
conclusion.
29+
30+
Before opening a pull request, we kindly ask you to consider opening a
31+
[discussion](https://github.com/serverlessworkflow/specification/discussions)
32+
or an [issue](https://github.com/serverlessworkflow/specification/issues). The
33+
community will be more than happy to discuss your proposals there.
34+
35+
Having the discussion or issue settled, please submit a
36+
[pull request](https://github.com/serverlessworkflow/specification/pulls) (PR)
37+
with the complete set of changes discussed with the community. See the
2538
[Spec Formatting Conventions](#spec-formatting-conventions) section for the
2639
guidelines we follow for how documents are formatted.
2740

28-
Each PR must be signed per the following section.
41+
Each PR must be signed per the following section and have a link to the issue or
42+
discussion.
43+
44+
### Fixing Typos, Spelling, and Formatting issues
45+
46+
Due to the amount of text a specification can have, typos, spelling, and
47+
formatting issues are pretty common. In these cases, please submit a
48+
[pull request](https://github.com/serverlessworkflow/specification/pulls)
49+
directly only with the fixes that you see fit.
2950

3051
### Assigning and Owning work
3152

@@ -45,22 +66,22 @@ Documents in this repository will adhere to the following rules:
4566

4667
### Markdown style
4768

48-
Markdown files should be properly formatted before a pull request is sent out.
49-
In this repository we follow the
69+
Markdown files should be appropriately formatted before a pull request is sent out.
70+
In this repository, we follow the
5071
[markdownlint rules](https://github.com/DavidAnson/markdownlint#rules--aliases)
5172
with some customizations. See [markdownlint](.markdownlint.yaml) or
5273
[settings](.vscode/settings.json) for details.
5374

54-
We highly encourage to use line breaks in markdown files at `80` characters
55-
wide. There are tools that can do it for you effectively. Please submit proposal
56-
to include your editor settings required to enable this behavior so the out of
57-
the box settings for this repository will be consistent.
75+
We highly encourage using line breaks in markdown files at `80` characters
76+
wide. Some tools can do it for you effectively. Please submit the proposal
77+
to include your editor settings required to enable this behavior so the
78+
out-of-the-box settings for this repository will be consistent.
5879

5980
If you are using Visual Studio Code,
6081
you can also use the `fixAll` command of the
6182
[vscode markdownlint extension](https://github.com/DavidAnson/vscode-markdownlint).
6283

63-
To otherwise check for style violations, use
84+
To otherwise check for style violations, use:
6485

6586
```bash
6687
# Ruby and gem are required for mdl
@@ -84,7 +105,7 @@ make install-misspell
84105
make misspell
85106
```
86107

87-
To quickly fix typos, use
108+
To quickly fix typos, use:
88109

89110
```bash
90111
make misspell-correction

0 commit comments

Comments
 (0)