Skip to content

Commit 45c22a1

Browse files
committed
fix(Runner): Fixed the TaskExecutor to ignore both output.as and export.as clauses for skipped tasks
Fixes #481 Signed-off-by: Charles d'Avernas <[email protected]>
1 parent c7c818c commit 45c22a1

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

src/runner/Synapse.Runner/Services/TaskExecutor.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -379,20 +379,6 @@ public virtual async Task SkipAsync(object? result, string? then = FlowDirective
379379
this.Stopwatch.Stop();
380380
if (string.IsNullOrWhiteSpace(then)) then = FlowDirective.Continue;
381381
var output = result;
382-
var arguments = this.GetExpressionEvaluationArguments() ?? new Dictionary<string, object>();
383-
arguments[RuntimeExpressions.Arguments.Output] = output!;
384-
if (this.Task.Definition.Output?.As is string fromExpression) output = await this.Task.Workflow.Expressions.EvaluateAsync<object>(fromExpression, output ?? new(), arguments, cancellationToken).ConfigureAwait(false);
385-
else if (this.Task.Definition.Output?.As != null) output = await this.Task.Workflow.Expressions.EvaluateAsync<object>(this.Task.Definition.Output.As, output ?? new(), arguments, cancellationToken).ConfigureAwait(false);
386-
if (this.Task.Definition.Export?.As is string toExpression)
387-
{
388-
var context = (await this.Task.Workflow.Expressions.EvaluateAsync<IDictionary<string, object>>(toExpression, this.Task.ContextData, arguments, cancellationToken).ConfigureAwait(false))!;
389-
await this.Task.SetContextDataAsync(context, cancellationToken).ConfigureAwait(false);
390-
}
391-
else if (this.Task.Definition.Export?.As != null)
392-
{
393-
var context = (await this.Task.Workflow.Expressions.EvaluateAsync<IDictionary<string, object>>(this.Task.Definition.Export.As, this.Task.ContextData, this.GetExpressionEvaluationArguments(), cancellationToken).ConfigureAwait(false))!;
394-
await this.Task.SetContextDataAsync(context, cancellationToken).ConfigureAwait(false);
395-
}
396382
await this.Task.SkipAsync(output, then, cancellationToken).ConfigureAwait(false);
397383
this.Subject.OnNext(new TaskLifeCycleEvent(TaskLifeCycleEventType.Skipped));
398384
this.Subject.OnCompleted();

0 commit comments

Comments
 (0)