Merge pull request #385 from serverlessworkflow/fix-docker-image-tag

cdavernas · web-flow · commit 777ef318370d · 2024-09-05T09:54:21.000+02:00
Fix the DockerContainerPlatform to pull images by tag
diff --git a/src/core/Synapse.Core.Infrastructure.Containers.Docker/DockerContainerPlatform.cs b/src/core/Synapse.Core.Infrastructure.Containers.Docker/DockerContainerPlatform.cs
@@ -83,7 +83,10 @@ public virtual async Task<IContainer> CreateAsync(ContainerProcessDefinition def
         catch (DockerApiException ex) when (ex.StatusCode == HttpStatusCode.NotFound)
         {
             var downloadProgress = new Progress<JSONMessage>();
-            await this.DockerClient.Images.CreateImageAsync(new() { FromImage = definition.Image }, new(), downloadProgress, cancellationToken).ConfigureAwait(false);
+            var imageComponents = definition.Image.Split(':');
+            var imageName = imageComponents[0];
+            var imageTag = imageComponents.Length > 1 ? imageComponents[1] : null;
+            await this.DockerClient.Images.CreateImageAsync(new() { FromImage = imageName, Tag = imageTag }, new(), downloadProgress, cancellationToken).ConfigureAwait(false);
         }
         var parameters = new CreateContainerParameters()
         {

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,10 @@ public virtual async Task<IContainer> CreateAsync(ContainerProcessDefinition def`
`83`	`83`	`catch (DockerApiException ex) when (ex.StatusCode == HttpStatusCode.NotFound)`
`84`	`84`	`{`
`85`	`85`	`var downloadProgress = new Progress<JSONMessage>();`
`86`		`- await this.DockerClient.Images.CreateImageAsync(new() { FromImage = definition.Image }, new(), downloadProgress, cancellationToken).ConfigureAwait(false);`
	`86`	`+ var imageComponents = definition.Image.Split(':');`
	`87`	`+ var imageName = imageComponents[0];`
	`88`	`+ var imageTag = imageComponents.Length > 1 ? imageComponents[1] : null;`
	`89`	`+ await this.DockerClient.Images.CreateImageAsync(new() { FromImage = imageName, Tag = imageTag }, new(), downloadProgress, cancellationToken).ConfigureAwait(false);`
`87`	`90`	`}`
`88`	`91`	`var parameters = new CreateContainerParameters()`
`89`	`92`	`{`