fix(Dashboard.StateManagement): calling cancel before disposing of the cancellation token source in the component store

JBBianchi · JBBianchi · commit fafefdf6f3b7 · 2024-08-28T12:10:21.000+02:00
Signed-off-by: Jean-Baptiste Bianchi &lt;jb.bianchi@neuroglia.io&gt;
diff --git a/src/dashboard/Synapse.Dashboard.StateManagement/ComponentStore.cs b/src/dashboard/Synapse.Dashboard.StateManagement/ComponentStore.cs
@@ -89,6 +89,7 @@ protected virtual void Dispose(bool disposing)
         {
             if (disposing)
             {
+                this.CancellationTokenSource.Cancel();
                 this.CancellationTokenSource.Dispose();
                 this._subject.Dispose();
             }
@@ -114,6 +115,7 @@ protected virtual ValueTask DisposeAsync(bool disposing)
         {
             if (disposing)
             {
+                this.CancellationTokenSource.Cancel();
                 this.CancellationTokenSource.Dispose();
                 this._subject.Dispose();
             }

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ protected virtual void Dispose(bool disposing)`
`89`	`89`	`{`
`90`	`90`	`if (disposing)`
`91`	`91`	`{`
	`92`	`+ this.CancellationTokenSource.Cancel();`
`92`	`93`	`this.CancellationTokenSource.Dispose();`
`93`	`94`	`this._subject.Dispose();`
`94`	`95`	`}`
`@@ -114,6 +115,7 @@ protected virtual ValueTask DisposeAsync(bool disposing)`
`114`	`115`	`{`
`115`	`116`	`if (disposing)`
`116`	`117`	`{`
	`118`	`+ this.CancellationTokenSource.Cancel();`
`117`	`119`	`this.CancellationTokenSource.Dispose();`
`118`	`120`	`this._subject.Dispose();`
`119`	`121`	`}`