Add support for expand #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding mulitple hosts on a single cloudflare domain, the additional domains will be added as "Subject Alternative Name" and the certificate will need to be updated. Since the default setting in certbot is to ask, this fails. This change adds support for CERTBOT_EXPAND, which when set to true, will add the `--expand` option on the certbot run.
Removed entry for CERTBOT_EXPAND in Dockerfile as it's optional. Updated docs to include CERTBOT_EXPAND
Updated README to clarify usage of CERTBOT_DOMAINS and introduced CERTBOT_CERT_NAME for explicit certificate management. Marked CERTBOT_EXPAND as deprecated, recommending the use of CERTBOT_CERT_NAME instead. Adjusted Dockerfile to include new environment variable and set default values accordingly.
|
Thanks for your patience on this! I had a lot of open source work that I had drown my inbox 😅 I just pushed up some changes. Please take a look. Things I changed:
Try it out and let me know your thoughts! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding mulitple hosts on a single cloudflare domain, the additional domains will be added as "Subject Alternative Name" and the certificate will need to be updated. Since the default setting in certbot is to ask, this fails.
This change adds support for CERTBOT_EXPAND, which when set to true, will add the
--expandoption on the certbot run.Fixes #20