Auto merge of #344 - mozfreddyb:patch-1, r=jdm

bors-servo · web-flow · commit 7ec6509641c4 · 2018-08-20T16:53:29.000-04:00
Remove unrequired assertion for invalid markup (fixes #305)
diff --git a/html5ever/src/tokenizer/mod.rs b/html5ever/src/tokenizer/mod.rs
@@ -550,8 +550,7 @@ impl<Sink: TokenSink> Tokenizer<Sink> {
     }
 
     fn discard_char(&mut self, input: &mut BufferQueue) {
-        let c = self.get_char(input);
-        assert!(c.is_some());
+        self.get_char(input);
     }
 
     fn emit_error(&mut self, error: Cow<'static, str>) {
diff --git a/html5ever/tests/serializer.rs b/html5ever/tests/serializer.rs
@@ -135,6 +135,7 @@ macro_rules! test_no_parse {
 
 
 test!(empty, r#""#);
+test!(fuzz, "<a a=\r\n", "");
 test!(smoke_test, r#"<p><i>Hello</i>, World!</p>"#);
 
 test!(misnest, r#"<p><i>Hello!</p>, World!</i>"#,

Original file line number	Diff line number	Diff line change
`@@ -550,8 +550,7 @@ impl<Sink: TokenSink> Tokenizer<Sink> {`
`550`	`550`	`}`
`551`	`551`
`552`	`552`	`fn discard_char(&mut self, input: &mut BufferQueue) {`
`553`		`- let c = self.get_char(input);`
`554`		`- assert!(c.is_some());`
	`553`	`+ self.get_char(input);`
`555`	`554`	`}`
`556`	`555`
`557`	`556`	`fn emit_error(&mut self, error: Cow<'static, str>) {`