Skip to content

Commit 6899bd2

Browse files
Loirooriolmukilan
authored andcommitted
Add helper function for defining focus areas
Most focus areas have the same name and prefix predicate, so it's easier to generate them with a helper function. This also brings consistency, since some names were omitting the final slash but other names were including it. Signed-off-by: Oriol Brufau <[email protected]>
1 parent 6596cc8 commit 6899bd2

File tree

2 files changed

+40
-93
lines changed

2 files changed

+40
-93
lines changed

process-wpt-results.js

Lines changed: 34 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -82,99 +82,46 @@ function prefix_predicate (prefix) {
8282
return test_name => test_name.startsWith(prefix)
8383
}
8484

85-
const CSS2_FOCUS_FOLDERS = [
86-
'abspos',
87-
'box-display',
88-
'floats',
89-
'floats-clear',
90-
'linebox',
91-
'margin-padding-clear',
92-
'normal-flow',
93-
'positioning'
94-
]
95-
96-
const CSS_TABLES_PREDICATE = /^\/css\/(CSS2\/tables|css-tables)\//
85+
function prefix_area (prefix) {
86+
return {
87+
name: prefix,
88+
predicate: prefix_predicate(prefix)
89+
}
90+
}
9791

9892
const FOCUS_AREAS = [
9993
{
10094
name: 'All WPT tests',
10195
predicate: prefix_predicate('')
10296
},
103-
{
104-
name: '/content-security-policy',
105-
predicate: prefix_predicate('/content-security-policy/')
106-
},
107-
{
108-
name: '/css',
109-
predicate: prefix_predicate('/css/')
110-
},
111-
{
112-
name: '/css/CSS2',
113-
predicate: prefix_predicate('/css/CSS2/')
114-
},
115-
...CSS2_FOCUS_FOLDERS.map(folder => {
116-
const path = `/css/CSS2/${folder}/`
117-
return {
118-
name: `${path}`,
119-
predicate: prefix_predicate(path)
120-
}
121-
}),
122-
{
123-
name: '/css/CSS2/tables & /css/css-tables',
124-
predicate: regex_predicate(CSS_TABLES_PREDICATE)
125-
},
126-
{
127-
name: '/css/cssom',
128-
predicate: prefix_predicate('/css/cssom/')
129-
},
130-
{
131-
name: '/css/css-align',
132-
predicate: prefix_predicate('/css/css-align/')
133-
},
134-
{
135-
name: '/css/css-flexbox',
136-
predicate: prefix_predicate('/css/css-flexbox/')
137-
},
138-
{
139-
name: '/css/css-grid',
140-
predicate: prefix_predicate('/css/css-grid/')
141-
},
142-
{
143-
name: '/css/css-position',
144-
predicate: prefix_predicate('/css/css-position/')
145-
},
146-
{
147-
name: '/css/css-sizing',
148-
predicate: prefix_predicate('/css/css-sizing/')
149-
},
150-
{
151-
name: '/css/css-text',
152-
predicate: prefix_predicate('/css/css-text/')
153-
},
154-
{
155-
name: '/gamepad',
156-
predicate: prefix_predicate('/gamepad/')
157-
},
158-
{
159-
name: '/shadow-dom',
160-
predicate: prefix_predicate('/shadow-dom/')
161-
},
162-
{
163-
name: '/streams',
164-
predicate: prefix_predicate('/streams/')
165-
},
166-
{
167-
name: '/trusted-types',
168-
predicate: prefix_predicate('/trusted-types/')
169-
},
170-
{
171-
name: '/WebCryptoAPI',
172-
predicate: prefix_predicate('/WebCryptoAPI/')
173-
},
174-
{
175-
name: '/webxr',
176-
predicate: prefix_predicate('/webxr/')
177-
}
97+
prefix_area('/content-security-policy/'),
98+
prefix_area('/css/'),
99+
prefix_area('/css/CSS2/'),
100+
prefix_area('/css/CSS2/abspos/'),
101+
prefix_area('/css/CSS2/box-display/'),
102+
prefix_area('/css/CSS2/floats/'),
103+
prefix_area('/css/CSS2/floats-clear/'),
104+
prefix_area('/css/CSS2/linebox/'),
105+
prefix_area('/css/CSS2/margin-padding-clear/'),
106+
prefix_area('/css/CSS2/normal-flow/'),
107+
prefix_area('/css/CSS2/positioning/'),
108+
{
109+
name: '/css/CSS2/tables/ & /css/css-tables/',
110+
predicate: regex_predicate(/^\/css\/(CSS2\/tables|css-tables)\//)
111+
},
112+
prefix_area('/css/cssom/'),
113+
prefix_area('/css/css-align/'),
114+
prefix_area('/css/css-flexbox/'),
115+
prefix_area('/css/css-grid/'),
116+
prefix_area('/css/css-position/'),
117+
prefix_area('/css/css-sizing/'),
118+
prefix_area('/css/css-text/'),
119+
prefix_area('/gamepad/'),
120+
prefix_area('/shadow-dom/'),
121+
prefix_area('/streams/'),
122+
prefix_area('/trusted-types/'),
123+
prefix_area('/WebCryptoAPI/'),
124+
prefix_area('/webxr/')
178125
]
179126

180127
export function get_focus_areas () {

test/process-wpt-results.test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -511,20 +511,20 @@ describe('focus areas', () => {
511511
assert.deepEqual(map, {
512512
'/css/CSS2/floats-clear/float-replaced-width-004.xht': [
513513
'All WPT tests',
514-
'/css',
515-
'/css/CSS2',
514+
'/css/',
515+
'/css/CSS2/',
516516
'/css/CSS2/floats-clear/'
517517
],
518518
'/css/CSS2/abspos/static-inside-table-cell.html': [
519519
'All WPT tests',
520-
'/css',
521-
'/css/CSS2',
520+
'/css/',
521+
'/css/CSS2/',
522522
'/css/CSS2/abspos/'
523523
],
524524
'/css/CSS2/margin-padding-clear/margin-right-078.xht': [
525525
'All WPT tests',
526-
'/css',
527-
'/css/CSS2',
526+
'/css/',
527+
'/css/CSS2/',
528528
'/css/CSS2/margin-padding-clear/'
529529
],
530530
'/workers/semantics/multiple-workers/001.html': [

0 commit comments

Comments
 (0)