Skip to content

Commit f56e93e

Browse files
committed
Stop using area_keys
See servo/internal-wpt-dashboard#62 Signed-off-by: Oriol Brufau <[email protected]>
1 parent a97ae95 commit f56e93e

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

assets/js/load-chart.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,8 @@ function setupChart () {
117117

118118
function update_chart () {
119119
if (!all_scores) throw new Error('scores not loaded')
120-
const chosen_area = area_dropdown.value
120+
const area_index = +area_dropdown.value
121121
const chosen_period = period_dropdown.value
122-
const area_index = all_scores.area_keys.indexOf(chosen_area)
123122
const table = new google.visualization.DataTable()
124123
options.series = []
125124
const monthsToSubtract = periodRanges[chosen_period]
@@ -164,10 +163,10 @@ function setupChart () {
164163
options.hAxis.format = 'MMM YYYY'
165164
}
166165

167-
for (const area of scores.area_keys) {
166+
for (const [index, area] of scores.focus_areas.entries()) {
168167
const selector = document.createElement('option')
169-
selector.value = area
170-
selector.textContent = scores.focus_areas[area]
168+
selector.value = index
169+
selector.textContent = area
171170
area_dropdown.appendChild(selector)
172171
}
173172

@@ -193,7 +192,7 @@ function setupChart () {
193192
update_chart()
194193
})
195194
}
196-
area_dropdown.value = scores.area_keys[0]
195+
area_dropdown.value = 0
197196
period_dropdown.value = Object.keys(periodRanges)[4]
198197
update_chart()
199198
})

assets/js/load-table.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ function update_table (scores) {
1313
const score_table = document.getElementById('score-table-body')
1414
removeChildren(score_table)
1515

16-
for (const [idx, area] of scores.area_keys.entries()) {
16+
for (const [idx, area] of scores.focus_areas.entries()) {
1717
const area_score = scores.scores_last_run[idx + AREA_SCORE_OFFSET]
1818
const score = Math.floor(1000 * area_score.total_score / area_score.total_tests) / 10
1919
const subtests = Math.floor(1000 * area_score.total_subtests_passed / area_score.total_subtests) / 10
2020
score_table.insertAdjacentHTML(
2121
'beforeend',
2222
`<tr class="${idx % 2 ? 'odd' : 'even'}">
23-
<td>${scores.focus_areas[area]}</td>
23+
<td>${area}</td>
2424
<td class="score">${String(score).padEnd(4, '.0')}%</td>
2525
<td class="score">(${new Intl.NumberFormat().format(area_score.total_subtests_passed)}/${new Intl.NumberFormat().format(area_score.total_subtests)}) ${String(subtests).padEnd(4, '.0')}%</td>
2626
</tr>`

0 commit comments

Comments
 (0)