From 151aa5174dde04c57c1196c0883e51342d888048 Mon Sep 17 00:00:00 2001 From: SessionHero01 Date: Wed, 25 Jun 2025 10:05:51 +1000 Subject: [PATCH] Fix an incorrect usage of NewStringUTF --- library/src/main/cpp/logging.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/library/src/main/cpp/logging.cpp b/library/src/main/cpp/logging.cpp index 547df2a..a872ad9 100644 --- a/library/src/main/cpp/logging.cpp +++ b/library/src/main/cpp/logging.cpp @@ -31,9 +31,13 @@ Java_network_loki_messenger_libsession_1util_util_Logger_00024Companion_addLogge return; // Failed to attach thread, cannot log } + // Java strings need null-terminated C strings, we'll have to copy them here unfortunately + std::string msg_str(msg); + std::string category_str(category); + env->CallVoidMethod(loggerRef, logMethod, - JavaLocalRef(env, env->NewStringUTF(msg.data())).get(), - JavaLocalRef(env, env->NewStringUTF(category.data())).get(), + JavaLocalRef(env, env->NewStringUTF(msg_str.c_str())).get(), + JavaLocalRef(env, env->NewStringUTF(category_str.c_str())).get(), static_cast(level.level) ); });