fix: gen supplemental keys once for all new members

Author: Bilb

src/groups/meta_group_wrapper.cpp

@@ -704,14 +704,14 @@ Napi::Value MetaGroupWrapper::generateSupplementKeys(const Napi::CallbackInfo& i
         uint32_t arrayLength = membersJS.Length();
         std::vector<std::string> membersToAdd;
         membersToAdd.reserve(arrayLength);
-        std::vector<ustring> keyMessages;
-        keyMessages.reserve(arrayLength);
+        std::vector<std::string> membersCpp;
+        membersCpp.reserve(arrayLength);
 
         for (uint32_t i = 0; i < membersJS.Length(); i++) {
             auto memberPk = toCppString(membersJS[i], __PRETTY_FUNCTION__);
-            keyMessages.push_back(this->meta_group->keys->key_supplement(memberPk));
+            membersCpp.push_back(memberPk);
         }
-        return keyMessages;
+        return this->meta_group->keys->key_supplement(membersCpp);
     });
 }
 

types/groups/groupkeys.d.ts

@@ -13,7 +13,7 @@ declare module 'libsession_util_nodejs' {
     encryptMessages: (plaintexts: Array<Uint8Array>) => Array<Uint8Array>;
     decryptMessage: (ciphertext: Uint8Array) => { pubkeyHex: string; plaintext: Uint8Array };
     makeSwarmSubAccount: (memberPubkeyHex: PubkeyType) => Uint8ArrayLen100;
-    generateSupplementKeys: (membersPubkeyHex: Array<PubkeyType>) => Array<Uint8Array>;
+    generateSupplementKeys: (membersPubkeyHex: Array<PubkeyType>) => Uint8Array;
     swarmSubaccountSign: (
       message: Uint8Array,
       authData: Uint8ArrayLen100

types/groups/groupmembers.d.ts

@@ -17,7 +17,12 @@ declare module 'libsession_util_nodejs' {
     inviteFailed: boolean;
     promotionPending: boolean;
     promotionFailed: boolean;
-    removedStatus: number; // 0 = not removed, 1 means removed, 2 means removed with messages
+    /**
+     * - 0 means not removed,
+     * - 1 means removed (libsession: REMOVED_MEMBER),
+     * - 2 means removed with messages  (libsession: REMOVED_MEMBER_AND_MESSAGES)
+     */
+    removedStatus: number;
     promoted: boolean;
     admin: boolean;
   };