chore: remove getProfilePicWithKeyHex

Author: Bilb

include/user_config.hpp

@@ -20,7 +20,6 @@ class UserConfigWrapper : public ConfigBaseImpl, public Napi::ObjectWrap<UserCon
     Napi::Value getPriority(const Napi::CallbackInfo& info);
     Napi::Value getName(const Napi::CallbackInfo& info);
     Napi::Value getProfilePic(const Napi::CallbackInfo& info);
-    Napi::Value getProfilePicWithKeyHex(const Napi::CallbackInfo& info);
 
     void setPriority(const Napi::CallbackInfo& info);
     void setName(const Napi::CallbackInfo& info);

include/utilities.hpp

@@ -149,9 +149,11 @@ struct toJs_impl<std::vector<unsigned char>> {
 template <>
 struct toJs_impl<std::vector<std::byte>> {
     auto operator()(const Napi::Env& env, std::vector<std::byte> b) const {
-        auto data = b.data();
-        auto data_uchar = reinterpret_cast<const unsigned char*>(data, b.size());
-        return Napi::Buffer<uint8_t>::Copy(env, data_uchar, b.size());
+        return Napi::Buffer<uint8_t>::Copy(
+            env,
+            reinterpret_cast<const unsigned char*>(b.data()),
+            b.size()
+        );
     }
 };
 

src/user_config.cpp

@@ -20,8 +20,6 @@ void UserConfigWrapper::Init(Napi::Env env, Napi::Object exports) {
                     InstanceMethod("getPriority", &UserConfigWrapper::getPriority),
                     InstanceMethod("getName", &UserConfigWrapper::getName),
                     InstanceMethod("getProfilePic", &UserConfigWrapper::getProfilePic),
-                    InstanceMethod(
-                            "getProfilePicWithKeyHex", &UserConfigWrapper::getProfilePicWithKeyHex),
                     InstanceMethod(
                             "getProfileUpdatedSeconds",
                             &UserConfigWrapper::getProfileUpdatedSeconds),
@@ -143,18 +141,6 @@ Napi::Value UserConfigWrapper::getProfileUpdatedSeconds(const Napi::CallbackInfo
     });
 }
 
-Napi::Value UserConfigWrapper::getProfilePicWithKeyHex(const Napi::CallbackInfo& info) {
-    return wrapResult(info, [&]() -> std::optional<std::string> {
-        auto env = info.Env();
-        auto pic = config.get_profile_pic();
-        // if pic.key and url are set, return a combined string with both merged by a hash, and the
-        // key in hex
-        if (!pic.url.empty() && !pic.key.empty()) {
-            return std::string(pic.url + "#" + to_hex(pic.key));
-        }
-        return std::nullopt;
-    });
-}
 
 Napi::Value UserConfigWrapper::getEnableBlindedMsgRequest(const Napi::CallbackInfo& info) {
     return wrapResult(info, [&] {

types/user/userconfig.d.ts

@@ -28,13 +28,6 @@ declare module 'libsession_util_nodejs' {
     setReuploadProfilePic: (pic: ProfilePicture) => void;
 
     getProfileUpdatedSeconds: () => number;
-    /**
-     * Returns the profile picture url and key merged as a url fragment, or null if not set.
-     * So this could return something like
-     * `http://filev2.getsession.org/file/1234#ba7e23ef3d4dc54b706d79c149ec571a4d64043e13771236afc030f6c8118575`
-     *
-     */
-    getProfilePicWithKeyHex: () => string | undefined;
 
     setEnableBlindedMsgRequest: (msgRequest: boolean) => void;
     getEnableBlindedMsgRequest: () => boolean | undefined;
@@ -61,7 +54,6 @@ declare module 'libsession_util_nodejs' {
     public setNewProfilePic: UserConfigWrapper['setNewProfilePic'];
     public setReuploadProfilePic: UserConfigWrapper['setReuploadProfilePic'];
     public getProfileUpdatedSeconds: UserConfigWrapper['getProfileUpdatedSeconds'];
-    public getProfilePicWithKeyHex: UserConfigWrapper['getProfilePicWithKeyHex'];
     public getEnableBlindedMsgRequest: UserConfigWrapper['getEnableBlindedMsgRequest'];
     public setEnableBlindedMsgRequest: UserConfigWrapper['setEnableBlindedMsgRequest'];
     public getNoteToSelfExpiry: UserConfigWrapper['getNoteToSelfExpiry'];
@@ -85,7 +77,6 @@ declare module 'libsession_util_nodejs' {
     | MakeActionCall<UserConfigWrapper, 'setNewProfilePic'>
     | MakeActionCall<UserConfigWrapper, 'setReuploadProfilePic'>
     | MakeActionCall<UserConfigWrapper, 'getProfileUpdatedSeconds'>
-    | MakeActionCall<UserConfigWrapper, 'getProfilePicWithKeyHex'>
     | MakeActionCall<UserConfigWrapper, 'getEnableBlindedMsgRequest'>
     | MakeActionCall<UserConfigWrapper, 'setEnableBlindedMsgRequest'>
     | MakeActionCall<UserConfigWrapper, 'getNoteToSelfExpiry'>