Skip to content

Commit 49943d4

Browse files
committed
fix: pr review & unit test fixes
1 parent 6079030 commit 49943d4

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

include/pro/pro.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ class ProWrapper : public Napi::ObjectWrap<ProWrapper> {
343343
toCppString(master_privkey_js, "proStatusRequestBody.masterPrivKeyHex");
344344

345345
auto master_privkey_decoded = from_hex(master_privkey);
346-
assert_length(master_privkey_decoded, 64, "proStatusRequestBody.masterPrivKeyHex");
346+
assert_length(master_privkey_decoded, 32, "proStatusRequestBody.masterPrivKeyHex");
347347

348348
auto json = pro_backend::GetProStatusRequest::build_to_json(
349349
static_cast<uint8_t>(requestVersion.Int32Value()),

src/utilities.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,6 @@ confirm_pushed_entry_t confirm_pushed_entry_from_JS(const Napi::Env& env, const
354354

355355
Napi::BigInt proFeaturesToJsBitset(
356356
const Napi::Env& env, const SESSION_PROTOCOL_PRO_FEATURES bitset) {
357-
// 2^53 should be enough for now. If we do need more we can use a bigint
358357
return Napi::BigInt::New(env, bitset);
359358
}
360359

0 commit comments

Comments
 (0)