feat: added COMMUNITY_FULL_URL_MAX_LENGTH

cleaned up CONSTANTS object creation

Author: yougotwill

shared.d.ts

@@ -72,7 +72,13 @@ declare module 'libsession_util_nodejs' {
     BASE_GROUP_MAX_NAME_LENGTH: number;
     /** 100 bytes */
     GROUP_INFO_MAX_NAME_LENGTH: number;
-  }
+    /** 411 bytes
+     * 
+     * COMMUNITY_BASE_URL_MAX_LENGTH + '/r/' + COMMUNITY_ROOM_MAX_LENGTH
+    qs_pubkey.size() + hex pubkey + null terminator
+    */
+    COMMUNITY_FULL_URL_MAX_LENGTH: number;
+  };
 
   export const CONSTANTS: ConstantsType;
 }

src/constants.cpp

@@ -1,5 +1,6 @@
 #include "constants.hpp"
 
+#include "session/config/community.h"
 #include "session/config/contacts.hpp"
 #include "session/config/groups/info.hpp"
 #include "session/config/user_groups.hpp"
@@ -9,28 +10,28 @@ ConstantsWrapper::ConstantsWrapper(const Napi::CallbackInfo& info) :
         Napi::ObjectWrap<ConstantsWrapper>(info) {}
 
 Napi::Object ConstantsWrapper::Init(Napi::Env env, Napi::Object exports) {
-    // fetch cpp constants
-    Napi::Number CONTACT_MAX_NAME_LENGTH =
-            Napi::Number::New(env, session::config::contact_info::MAX_NAME_LENGTH);
-    Napi::Number BASE_GROUP_MAX_NAME_LENGTH =
-            Napi::Number::New(env, session::config::base_group_info::NAME_MAX_LENGTH);
-    Napi::Number GROUP_INFO_MAX_NAME_LENGTH =
-            Napi::Number::New(env, session::config::groups::Info::NAME_MAX_LENGTH);
-
     const char* class_name = "CONSTANTS";
 
     // construct javascript constants object
     Napi::Function cls = DefineClass(
             env,
             class_name,
             {ObjectWrap::StaticValue(
-                     "CONTACT_MAX_NAME_LENGTH", CONTACT_MAX_NAME_LENGTH, napi_enumerable),
+                     "CONTACT_MAX_NAME_LENGTH",
+                     Napi::Number::New(env, session::config::contact_info::MAX_NAME_LENGTH),
+                     napi_enumerable),
              ObjectWrap::StaticValue(
-                     "BASE_GROUP_MAX_NAME_LENGTH", BASE_GROUP_MAX_NAME_LENGTH, napi_enumerable),
+                     "BASE_GROUP_MAX_NAME_LENGTH",
+                     Napi::Number::New(env, session::config::base_group_info::NAME_MAX_LENGTH),
+                     napi_enumerable),
              ObjectWrap::StaticValue(
-                     "GROUP_INFO_MAX_NAME_LENGTH", GROUP_INFO_MAX_NAME_LENGTH, napi_enumerable)
-
-            });
+                     "GROUP_INFO_MAX_NAME_LENGTH",
+                     Napi::Number::New(env, session::config::groups::Info::NAME_MAX_LENGTH),
+                     napi_enumerable),
+             ObjectWrap::StaticValue(
+                     "COMMUNITY_FULL_URL_MAX_LENGTH",
+                     Napi::Number::New(env, COMMUNITY_FULL_URL_MAX_LENGTH),
+                     napi_enumerable)});
 
     // export object as javascript module
     exports.Set(class_name, cls);