fix: constants now works correctly with correct typings!

updated gitignore file

Author: yougotwill

.gitignore

@@ -1,6 +1,9 @@
-/build/
-/.vscode/
+# ide files
 /.vscrof/
+/.vscode/
+/.idea/
+
+/build/
 /node_modules/
 /*.tar.gz
 /package-lock.json

shared.d.ts

@@ -64,14 +64,11 @@ declare module 'libsession_util_nodejs' {
   }
 
   export type BaseWrapperActionsCalls = MakeWrapperActionCalls<BaseConfigWrapper>;
-}
-
-/**
- * Constants wrapper logic
- */
 
-export type ConstantsWrapper = {
-  "CONSTANTS": {
-    MAX_NAME_LENGTH: number
+  export type ConstantsType = {
+    /** Maximum byte length for user, contact and group names  */
+    MAX_NAME_LENGTH: number;
   }
+
+  export const CONSTANTS: ConstantsType;
 }

src/constants.cpp

@@ -1,19 +1,28 @@
 #include "constants.hpp"
 
-namespace session::nodeapi {
-Napi::Number ConstantsWrapper::MAX_NAME_LENGTH;
+#include "session/config/contacts.hpp"
 
+namespace session::nodeapi {
 ConstantsWrapper::ConstantsWrapper(const Napi::CallbackInfo& info) :
         Napi::ObjectWrap<ConstantsWrapper>(info) {}
 
 Napi::Object ConstantsWrapper::Init(Napi::Env env, Napi::Object exports) {
-    MAX_NAME_LENGTH = Napi::Number::New(env, session::config::contact_info::MAX_NAME_LENGTH);
+    // fetch cpp constants
+    Napi::Number MAX_NAME_LENGTH =
+            Napi::Number::New(env, session::config::contact_info::MAX_NAME_LENGTH);
 
-    Napi::Object constants = Napi::Object::New(env);
-    constants.Set("MAX_NAME_LENGTH", MAX_NAME_LENGTH);
+    const char* class_name = "CONSTANTS";
 
-    exports.Set("CONSTANTS", constants);
+    // construct javascript constants object
+    Napi::Function cls = DefineClass(
+            env,
+            class_name,
+            {ObjectWrap::StaticValue("MAX_NAME_LENGTH", MAX_NAME_LENGTH, napi_enumerable)});
+
+    // export object as javascript module
+    exports.Set(class_name, cls);
     return exports;
 }
 
 }  // namespace session::nodeapi
+

src/constants.hpp

@@ -2,15 +2,12 @@
 
 #include <napi.h>
 
-#include "session/config/contacts.hpp"
-
 namespace session::nodeapi {
 class ConstantsWrapper : public Napi::ObjectWrap<ConstantsWrapper> {
   public:
-    static Napi::Object Init(Napi::Env env, Napi::Object exports);
     ConstantsWrapper(const Napi::CallbackInfo& info);
 
-  private:
-    static Napi::Number MAX_NAME_LENGTH;
+    static Napi::Object Init(Napi::Env env, Napi::Object exports);
 };
 }  // namespace session::nodeapi
+