Skip to content

Commit 575632b

Browse files
committed
SES-4301 - Using accent text to help with contrast
1 parent 6ccf18e commit 575632b

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

app/src/main/java/org/thoughtcrime/securesms/reviews/ui/InAppReview.kt

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import androidx.compose.runtime.setValue
1616
import androidx.compose.ui.platform.LocalContext
1717
import androidx.compose.ui.text.AnnotatedString
1818
import androidx.compose.ui.tooling.preview.Preview
19+
import androidx.compose.ui.tooling.preview.PreviewParameter
1920
import androidx.core.net.toUri
2021
import androidx.lifecycle.Lifecycle
2122
import androidx.lifecycle.LifecycleEventObserver
@@ -36,6 +37,9 @@ import org.thoughtcrime.securesms.ui.DialogButtonData
3637
import org.thoughtcrime.securesms.ui.GetString
3738
import org.thoughtcrime.securesms.ui.OpenURLAlertDialog
3839
import org.thoughtcrime.securesms.ui.theme.LocalColors
40+
import org.thoughtcrime.securesms.ui.theme.PreviewTheme
41+
import org.thoughtcrime.securesms.ui.theme.SessionColorsParameterProvider
42+
import org.thoughtcrime.securesms.ui.theme.ThemeColors
3943

4044
private const val SESSION_FEEDBACK_BASE_URL = "https://getsession.org/feedback?platform=android"
4145

@@ -133,7 +137,7 @@ private fun InAppReviewDialog(
133137
buttons = listOf(
134138
DialogButtonData(
135139
text = GetString.FromString(positiveButtonText),
136-
color = LocalColors.current.accent,
140+
color = LocalColors.current.accentText,
137141
dismissOnClick = false
138142
) {
139143
sendCommands(InAppReviewViewModel.UiCommand.PositiveButtonClicked)
@@ -150,7 +154,6 @@ private fun InAppReviewDialog(
150154
}
151155

152156
@Composable
153-
@Preview
154157
private fun InAppReviewStartPrompt(
155158
sendCommands: (InAppReviewViewModel.UiCommand) -> Unit = {}
156159
) {
@@ -178,7 +181,6 @@ private fun InAppReviewStartPrompt(
178181
}
179182

180183
@Composable
181-
@Preview
182184
private fun InAppReviewPositivePrompt(
183185
storeReviewManager: StoreReviewManager? = null,
184186
sendCommands: (InAppReviewViewModel.UiCommand) -> Unit = {}
@@ -202,10 +204,10 @@ private fun InAppReviewPositivePrompt(
202204
}
203205

204206
@Composable
205-
@Preview
206207
private fun InAppReviewNegativePrompt(
207208
sendCommands: (InAppReviewViewModel.UiCommand) -> Unit = {}
208209
) {
210+
209211
val context = LocalContext.current
210212

211213
InAppReviewDialog(
@@ -218,4 +220,14 @@ private fun InAppReviewNegativePrompt(
218220
negativeButtonText = context.getString(R.string.notNow),
219221
sendCommands = sendCommands
220222
)
223+
}
224+
225+
@Composable
226+
@Preview
227+
fun PreviewInAppReviewPrompt(
228+
@PreviewParameter(SessionColorsParameterProvider::class) colors: ThemeColors
229+
){
230+
PreviewTheme(colors = colors) {
231+
InAppReviewStartPrompt()
232+
}
221233
}

0 commit comments

Comments
 (0)