Skip to content

Commit b377640

Browse files
committed
SES-4619 - Special case of disabled color for buttons on bg secondary
1 parent 059f4b6 commit b377640

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

app/src/main/java/org/thoughtcrime/securesms/home/startconversation/community/JoinCommunityScreen.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@ private fun CommunityScreen(
183183
.fillMaxWidth()
184184
.qaTag(R.string.AccessibilityId_communityJoin),
185185
enabled = state.isJoinButtonEnabled,
186+
disabledColor = LocalColors.current.textSecondary,
186187
onClick = {
187188
sendCommand(JoinCommunityViewModel.Commands.JoinCommunity(
188189
state.communityUrl

app/src/main/java/org/thoughtcrime/securesms/home/startconversation/newmessage/NewMessage.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ private fun EnterAccountId(
139139
.fillMaxWidth()
140140
.qaTag(R.string.next),
141141
enabled = state.isNextButtonEnabled,
142+
disabledColor = LocalColors.current.textSecondary,
142143
onClick = callbacks::onContinue
143144
) {
144145
LoadingArcOr(state.loading) {

app/src/main/java/org/thoughtcrime/securesms/ui/components/Button.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,13 @@ fun Button(
162162
Button(text, onClick, ButtonType.Outline(LocalColors.current.accentText), modifier, enabled, minWidth = minWidth)
163163
}
164164

165-
@Composable fun AccentOutlineButton(modifier: Modifier = Modifier, enabled: Boolean = true, onClick: () -> Unit, content: @Composable RowScope.() -> Unit) {
166-
Button(onClick, ButtonType.Outline(LocalColors.current.accentText), modifier, enabled, content = content)
165+
@Composable fun AccentOutlineButton(modifier: Modifier = Modifier, enabled: Boolean = true,
166+
disabledColor: Color = LocalColors.current.disabled,
167+
onClick: () -> Unit, content: @Composable RowScope.() -> Unit) {
168+
Button(onClick, ButtonType.Outline(
169+
contentColor = LocalColors.current.accentText,
170+
disabledColor = disabledColor
171+
), modifier, enabled, content = content)
167172
}
168173

169174
@Composable fun SlimOutlineButton(modifier: Modifier = Modifier, color: Color = LocalColors.current.text, enabled: Boolean = true, onClick: () -> Unit, content: @Composable RowScope.() -> Unit) {

app/src/main/java/org/thoughtcrime/securesms/ui/components/ButtonType.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,19 @@ interface ButtonType {
2626

2727
class Outline(
2828
private val contentColor: Color,
29-
private val borderColor: Color = contentColor
29+
private val borderColor: Color = contentColor,
30+
private val disabledColor: Color? = null
3031
): ButtonType {
3132
@Composable
3233
override fun border(enabled: Boolean) = BorderStroke(
3334
width = LocalDimensions.current.borderStroke,
34-
color = if (enabled) borderColor else LocalColors.current.disabled
35+
color = if (enabled) borderColor else disabledColor ?: LocalColors.current.disabled
3536
)
3637
@Composable
3738
override fun buttonColors() = ButtonDefaults.buttonColors(
3839
contentColor = contentColor,
3940
containerColor = Color.Transparent,
40-
disabledContentColor = LocalColors.current.disabled,
41+
disabledContentColor = disabledColor ?: LocalColors.current.disabled,
4142
disabledContainerColor = Color.Transparent
4243
)
4344
}

0 commit comments

Comments
 (0)